Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Gradle system properties with spaces #219

Merged
merged 11 commits into from
Dec 20, 2023
Merged

Handle Gradle system properties with spaces #219

merged 11 commits into from
Dec 20, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Dec 12, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Handle scenarios where the Gradle command args contains system properties with space in its value.
  • For example: gradle clean -Dkey="some key"

@omerzi omerzi added the improvement Automatically generated release notes label Dec 12, 2023
@omerzi omerzi requested a review from yahavi December 12, 2023 14:19
@omerzi
Handle Gradle system properties with spaces
193894c
@omerzi
Merge remote-tracking branch 'origin/consider-gradle-system-propertie…
f419edd 
…s-with-space' into consider-gradle-system-properties-with-space

# Conflicts:
#	build/gradle.go
This was referenced Dec 13, 2023
Merged
Merged
@omerzi
Merge remote-tracking branch 'upstream/dev' into consider-gradle-syst…
980ea1b 
…em-properties-with-space

# Conflicts:
#	build/gradle.go
@omerzi omerzi requested a review from eyalbe4 December 17, 2023 09:50
@omerzi omerzi mentioned this pull request Dec 17, 2023
Closed
4 tasks
@eyalbe4 eyalbe4 added bug Something isn't working and removed improvement Automatically generated release notes labels Dec 20, 2023
@omerzi omerzi merged commit c8776c6 into jfrog:dev Dec 20, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @eyalbe4