Skip to content

Commit

Permalink
Add #[ReturnTypeWillChange] to internal PHP methods
Browse files Browse the repository at this point in the history
Suppress PHP 8.0+ deprecation notices from internal methods missing
explicit return types. This copies "laravel/framework" 8.x file
Illuminate\Database\Eloquent\Model.
  • Loading branch information
derekmd committed Jul 24, 2022
1 parent 7f037da commit 22fc190
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php: [7.1, 7.2, 7.3, 8.0]
php: [7.1, 7.2, 7.3, 8.0, 8.1]
steps:
- uses: actions/checkout@v2
- uses: shivammathur/setup-php@v2
Expand Down
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ php:
- 7.2
- 7.3
- 8.0
- 8.1

sudo: false

Expand Down
5 changes: 5 additions & 0 deletions src/Model.php
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ public function toJson($options = 0)
*
* @return array
*/
#[\ReturnTypeWillChange]
public function jsonSerialize()
{
return $this->toArray();
Expand Down Expand Up @@ -863,6 +864,7 @@ public function __set($key, $value)
* @param mixed $offset
* @return bool
*/
#[\ReturnTypeWillChange]
public function offsetExists($offset)
{
return isset($this->$offset);
Expand All @@ -874,6 +876,7 @@ public function offsetExists($offset)
* @param mixed $offset
* @return mixed
*/
#[\ReturnTypeWillChange]
public function offsetGet($offset)
{
return $this->$offset;
Expand All @@ -886,6 +889,7 @@ public function offsetGet($offset)
* @param mixed $value
* @return void
*/
#[\ReturnTypeWillChange]
public function offsetSet($offset, $value)
{
$this->$offset = $value;
Expand All @@ -897,6 +901,7 @@ public function offsetSet($offset, $value)
* @param mixed $offset
* @return void
*/
#[\ReturnTypeWillChange]
public function offsetUnset($offset)
{
unset($this->$offset);
Expand Down

0 comments on commit 22fc190

Please sign in to comment.