Handle legacy SC CLI options #232
Open
+332
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (optionsValue) { | ||
| isDeprecated = true; | ||
| deprecationText = "Legacy SC4 CLI commands are deprecated. Please update to SC5 style CLI flags." |
There was a problem hiding this comment.
Use field names, something like:
"Sauce Connect Legacy Options" is deprecated. Please use "Sauce Connect Options".
| <f:entry title="${%Sauce Connect Options}" field="sauceConnectOptions"> | ||
| <hr/> | ||
| <div id="validationMessage" style="color: red;"></div> | ||
| <div id="deprecationMessage" style="color: orange;"></div> |
There was a problem hiding this comment.
Is it possible to have the deprecation message right above the Sauce Connect Legacy Options text box?
Choraden
reviewed
Jan 15, 2025
| @@ -10,9 +10,9 @@ | |||
| <select name="restEndpoint"> | |||
| <option value="https://saucelabs.com/" selected="${instance.restEndpoint.equals('https://saucelabs.com/') ? 'true' : null}">US</option> | |||
| <option value="https://eu-central-1.saucelabs.com/" selected="${instance.restEndpoint.equals('https://eu-central-1.saucelabs.com/') ? 'true' : null}">EU</option> | |||
| <option value="https://us-east-1.saucelabs.com/" selected="${instance.restEndpoint.equals('https://us-east-1.saucelabs.com/') ? 'true' : null}">US_EAST</option> | |||
| <option value="https://us-east-1.saucelabs.com/" selected="${instance.restEndpoint.equals('https://us-east-1.saucelabs.com/') ? 'true' : null}">US_EAST 1 (deprecated)</option> | |||
There was a problem hiding this comment.
I wonder if deprecated notice fits it well. We might support it in the future, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on changes in saucelabs/ci-sauce#312