Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Commit

Permalink
Merge pull request #285 from dduportal/feat/bump-remoting/3063.v26e24…
Browse files Browse the repository at this point in the history
…490f041

Feat: prepare release 3063.v26e24490f041-1
  • Loading branch information
dduportal authored Sep 29, 2022
2 parents 6ac8068 + a1fd676 commit 80813f3
Show file tree
Hide file tree
Showing 12 changed files with 36 additions and 41 deletions.
4 changes: 2 additions & 2 deletions 11/alpine/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
# THE SOFTWARE.

#TODO(oleg_nenashev): Does it also need an update?
ARG version=latest-alpine-jdk11
FROM jenkins/agent:$version
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-alpine-jdk11

ARG version
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols" Vendor="Jenkins project" Version="$version"
Expand Down
4 changes: 2 additions & 2 deletions 11/debian/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

ARG version=4.9-1-jdk11
FROM jenkins/agent:$version
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-jdk11

ARG version
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols" Vendor="Jenkins project" Version="$version"
Expand Down
8 changes: 4 additions & 4 deletions 11/windows/nanoserver-1809/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

ARG VERSION=4.9-1
FROM jenkins/agent:${VERSION}-jdk11-nanoserver-1809
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-jdk11-nanoserver-1809

ARG VERSION
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$VERSION"
ARG version
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$version"

ARG user=jenkins

Expand Down
6 changes: 3 additions & 3 deletions 11/windows/windowsservercore-ltsc2019/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

ARG VERSION=4.9-1
FROM jenkins/agent:${VERSION}-jdk11-windowsservercore-ltsc2019
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-jdk11-windowsservercore-ltsc2019

LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$VERSION"
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$version"

ARG user=jenkins

Expand Down
4 changes: 2 additions & 2 deletions 17/alpine/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
# THE SOFTWARE.

#TODO(oleg_nenashev): Does it also need an update?
ARG version=latest-alpine-jdk17
FROM jenkins/agent:$version
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-alpine-jdk17

ARG version
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols" Vendor="Jenkins project" Version="$version"
Expand Down
4 changes: 2 additions & 2 deletions 17/debian/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG version=4.13.3-2-jdk17
FROM jenkins/agent:$version
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-jdk17

ARG version
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols" Vendor="Jenkins project" Version="$version"
Expand Down
8 changes: 4 additions & 4 deletions 17/windows/nanoserver-1809/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

ARG VERSION=4.9-1
FROM jenkins/agent:${VERSION}-jdk17-nanoserver-1809
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-jdk17-nanoserver-1809

ARG VERSION
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$VERSION"
ARG version
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$version"

ARG user=jenkins

Expand Down
6 changes: 3 additions & 3 deletions 17/windows/windowsservercore-ltsc2019/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

ARG VERSION=4.9-1
FROM jenkins/agent:${VERSION}-jdk17-windowsservercore-ltsc2019
ARG version=3063.v26e24490f041-1
FROM jenkins/agent:${version}-jdk17-windowsservercore-ltsc2019

LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$VERSION"
LABEL Description="This is a base image, which allows connecting Jenkins agents via JNLP protocols on Windows" Vendor="Jenkins Project" Version="$version"

ARG user=jenkins

Expand Down
12 changes: 6 additions & 6 deletions docker-bake.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ variable "BUILD_NUMBER" {
}

#### This is for the "parent" image to use: remoting version is interpolated from IMAGE_TAG) but parent image also have a build number suffix
variable "AGENT_IMAGE_BUILD_NUMBER" {
default = "1"
variable "PARENT_IMAGE_VERSION" {
default = "${REMOTING_VERSION}-1"
}

variable "REGISTRY" {
Expand All @@ -54,7 +54,7 @@ target "alpine_jdk11" {
dockerfile = "11/alpine/Dockerfile"
context = "."
args = {
version = "${REMOTING_VERSION}-${AGENT_IMAGE_BUILD_NUMBER}-alpine-jdk11"
version = "${PARENT_IMAGE_VERSION}"
}
tags = [
equal(ON_TAG, "true") ? "${REGISTRY}/${JENKINS_REPO}:${REMOTING_VERSION}-${BUILD_NUMBER}-alpine": "",
Expand All @@ -71,7 +71,7 @@ target "alpine_jdk17" {
dockerfile = "17/alpine/Dockerfile"
context = "."
args = {
version = "${REMOTING_VERSION}-${AGENT_IMAGE_BUILD_NUMBER}-alpine-jdk17"
version = "${PARENT_IMAGE_VERSION}"
}
tags = [
equal(ON_TAG, "true") ? "${REGISTRY}/${JENKINS_REPO}:${REMOTING_VERSION}-${BUILD_NUMBER}-alpine-jdk17": "",
Expand All @@ -85,7 +85,7 @@ target "debian_jdk11" {
dockerfile = "11/debian/Dockerfile"
context = "."
args = {
version = "${REMOTING_VERSION}-${AGENT_IMAGE_BUILD_NUMBER}-jdk11"
version = "${PARENT_IMAGE_VERSION}"
}
tags = [
equal(ON_TAG, "true") ? "${REGISTRY}/${JENKINS_REPO}:${REMOTING_VERSION}-${BUILD_NUMBER}": "",
Expand All @@ -101,7 +101,7 @@ target "debian_jdk17" {
dockerfile = "17/debian/Dockerfile"
context = "."
args = {
version = "${REMOTING_VERSION}-${AGENT_IMAGE_BUILD_NUMBER}-jdk17"
version = "${PARENT_IMAGE_VERSION}"
}
tags = [
equal(ON_TAG, "true") ? "${REGISTRY}/${JENKINS_REPO}:${REMOTING_VERSION}-${BUILD_NUMBER}-jdk17": "",
Expand Down
10 changes: 5 additions & 5 deletions make.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Param(
[String] $Target = "build",
[String] $AdditionalArgs = '',
[String] $Build = '',
[String] $VersionTag = '4.11.2-1',
[String] $VersionTag = '3063.v26e24490f041-1',
[String] $DockerAgentVersion = '3063.v26e24490f041-1',
[switch] $PushVersions = $false
)
Expand Down Expand Up @@ -48,7 +48,7 @@ if(![System.String]::IsNullOrWhiteSpace($Build) -and $builds.ContainsKey($Build)
foreach($tag in $builds[$Build]['Tags']) {
Copy-Item -Path 'jenkins-agent.ps1' -Destination (Join-Path $builds[$Build]['Folder'] 'jenkins-agent.ps1') -Force
Write-Host "Building $Build => tag=$tag"
$cmd = "docker build --build-arg 'VERSION={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $tag, $AdditionalArgs, $builds[$Build]['Folder']
$cmd = "docker build --build-arg 'version={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $tag, $AdditionalArgs, $builds[$Build]['Folder']
Invoke-Expression $cmd
$exitCodes += $lastExitCode

Expand All @@ -58,7 +58,7 @@ if(![System.String]::IsNullOrWhiteSpace($Build) -and $builds.ContainsKey($Build)
$buildTag = "$VersionTag"
}
Write-Host "Building $Build => tag=$buildTag"
$cmd = "docker build --build-arg 'VERSION={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $buildTag, $AdditionalArgs, $builds[$Build]['Folder']
$cmd = "docker build --build-arg 'version={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $buildTag, $AdditionalArgs, $builds[$Build]['Folder']
Invoke-Expression $cmd
$exitCodes += $lastExitCode
}
Expand All @@ -68,7 +68,7 @@ if(![System.String]::IsNullOrWhiteSpace($Build) -and $builds.ContainsKey($Build)
Copy-Item -Path 'jenkins-agent.ps1' -Destination (Join-Path $builds[$b]['Folder'] 'jenkins-agent.ps1') -Force
foreach($tag in $builds[$b]['Tags']) {
Write-Host "Building $b => tag=$tag"
$cmd = "docker build --build-arg 'VERSION={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $tag, $AdditionalArgs, $builds[$b]['Folder']
$cmd = "docker build --build-arg 'version={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $tag, $AdditionalArgs, $builds[$b]['Folder']
Invoke-Expression $cmd
$exitCodes += $lastExitCode

Expand All @@ -78,7 +78,7 @@ if(![System.String]::IsNullOrWhiteSpace($Build) -and $builds.ContainsKey($Build)
$buildTag = "$VersionTag"
}
Write-Host "Building $Build => tag=$buildTag"
$cmd = "docker build --build-arg 'VERSION={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $buildTag, $AdditionalArgs, $builds[$b]['Folder']
$cmd = "docker build --build-arg 'version={0}' -t {1}/{2}:{3} {4} {5}" -f $DockerAgentVersion, $Organization, $Repository, $buildTag, $AdditionalArgs, $builds[$b]['Folder']
Invoke-Expression $cmd
$exitCodes += $lastExitCode
}
Expand Down
7 changes: 1 addition & 6 deletions tests/inboundAgent.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,8 @@ Describe "[$global:JDK $global:FLAVOR] build args" {
BeforeAll {
Push-Location -StackName 'agent' -Path "$PSScriptRoot/.."
# an old jdk11 image version
$TEST_VERSION="4.7"
$TEST_VERSION="3063.v26e24490f041"
$DOCKER_AGENT_VERSION_SUFFIX="1"
if($global:JDK -eq '17') {
# the first jdk17 images for Windows
$TEST_VERSION = "4.10"
$DOCKER_AGENT_VERSION_SUFFIX="7"
}
$TEST_USER="foo"
$ARG_TEST_VERSION="${TEST_VERSION}-${DOCKER_AGENT_VERSION_SUFFIX}"
}
Expand Down
4 changes: 2 additions & 2 deletions tests/tests.bats
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ SUT_IMAGE=$(get_sut_image)
cd "${BATS_TEST_DIRNAME}"/.. || false

local ARG_TEST_VERSION
local TEST_VERSION="4.3"
local DOCKER_AGENT_VERSION_SUFFIX="4"
local TEST_VERSION="3063.v26e24490f041"
local DOCKER_AGENT_VERSION_SUFFIX="1"
local TEST_USER="root"
local ARG_TEST_VERSION="${TEST_VERSION}-${DOCKER_AGENT_VERSION_SUFFIX}"

Expand Down

0 comments on commit 80813f3

Please sign in to comment.