Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli): factorize helm chart manifests #5419

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jul 11, 2024

This PR factorizes helm chart manifests like what have been done for service principal writer end dates in https://github.com/jenkins-infra/azure.

It adds a charts entry in ./updatecli/values.yaml to define every information needed for helm chart manifests:

  • Chart name
    • Repository name (default: jenkins-infra)
    • Repository URL (default: https://jenkins-infra.github.io/helm-charts)
    • Targets
    • Additional labels (used for jenkinsistheway)

Two manifests have been moved from ./updatecli/updatecli.d/charts to ./updatecli/updatecli.d/ as they were not helm chart version bump manifests but specialized ones:

  • updatecli/updatecli.d/jenkins-agents-infra.ci.jenkins.io.yaml
  • updatecli/updatecli.d/jenkins-infra-tools-maven.yaml

Tested locally one by one then globally with updatecli diff --values updatecli/values.yaml --config updatecli/updatecli.d/charts.tpl.

From https://infra.ci.jenkins.io/job/updatecli/job/kubernetes-management/job/PR-5419/2/console:

 Run Summary
 ===========
 Pipeline(s) run:
   * Changed:	5
   * Failed:	0
   * Skipped:	0
   * Succeeded:	39
   * Total:	44

Fixes:

@lemeurherve lemeurherve added enhancement chore Chore/Non Functional Task/Cleanup updatecli labels Jul 11, 2024
@lemeurherve lemeurherve requested a review from a team July 11, 2024 15:08
@lemeurherve lemeurherve requested a review from a team as a code owner July 11, 2024 15:08
@lemeurherve
Copy link
Member Author

lemeurherve commented Jul 11, 2024

Added targets that were not covered before this PR in e157083

@lemeurherve lemeurherve deleted the factorize-updatecli-manifests branch July 11, 2024 15:43
@lemeurherve
Copy link
Member Author

Closed as no time for infra team to review before end of August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore/Non Functional Task/Cleanup enhancement updatecli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant