chore(updatecli): factorize helm chart manifests #5419
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factorizes helm chart manifests like what have been done for service principal writer end dates in https://github.com/jenkins-infra/azure.
It adds a
charts
entry in ./updatecli/values.yaml to define every information needed for helm chart manifests:jenkins-infra
)https://jenkins-infra.github.io/helm-charts
)Two manifests have been moved from ./updatecli/updatecli.d/charts to ./updatecli/updatecli.d/ as they were not helm chart version bump manifests but specialized ones:
Tested locally one by one then globally with
updatecli diff --values updatecli/values.yaml --config updatecli/updatecli.d/charts.tpl
.From https://infra.ci.jenkins.io/job/updatecli/job/kubernetes-management/job/PR-5419/2/console:
Fixes: