Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serverSetup.ts #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GitMensch
Copy link

* cleanup possibly broken vscode-server.tar.gz
* check for uname (see jeanp413#7)
@GitMensch
Copy link
Author

I've got into some bad "can not connect, download isn't redone" scenario which is solved by the first part. As an alternative for the second case (extracting does not work) we could output the full path instead of deletion, but I think "drop it if it doesn't work" option is good enough.

@GitMensch
Copy link
Author

As I now could reproduce the issue again (after each update) I see that the fix ("applied it manually" by deleting the file, then restarting the vscode window connected to WSL) I see another one that also applies to the open-ssh extension: if you are on Windows and use the "restart for update" option both have the same issue:

  • open two or more WSL workspaces to the same WSL instance in parallel
  • open two or more OpenSSH workspaces on the same target in parallel

when you now update and restart, those workspaces are opened directly after the start in parallel, the ones that connect to the same machine all find the server directory not being available - and then trying to download the reh file to the same place - the second one seems to interrupt the first one and you end with an invalid target file.

It could be useful to use a synchronization file to work around the race condition here.
... but even then this PR will provide a "works after the first click" until this is done and may fix other similar issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant