fix: Fixes infinite loop in auto install not found bash function #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This infinite loop bug is triggered when mise itself becomes not found, e.g., by deleting the directory mise is in.
bnorick
changed the title
|
Tests failed because I didn't update the test snap, I did that now. However, this made me realize that this'll need fixing for the other shells too, which I am not proficient in. |
|
The remaining test failure, related to |
jdx
reviewed
Jan 14, 2025
src/shell/bash.rs
Outdated
| @@ -71,7 +71,7 @@ impl Shell for Bash { | |||
| fi | |||
|
|
|||
| command_not_found_handle() {{ | |||
| if {exe} hook-not-found -s bash -- "$1"; then | |||
| if [ "$1" != "mise" ] && {exe} hook-not-found -s bash -- "$1"; then | |||
There was a problem hiding this comment.
this should match this logic
Line 95 in 801a880
|
I'd like at least support for zsh (which should be close to bash), fish would also be quite nice but the others I'm not so concerned about, I don't even think most of them have not_found handlers |
|
I didn't check whether the |
|
I am assuming either the tests cover this enough or you tested a bit 🤣 |
halostatue
added a commit
to halostatue/mise
that referenced
this pull request
Jan 17, 2025
An error for `fish_command_not_found` was introduce in jdx#4094 because glob misses do not work the same in fish as in other shells. As such, we are getting the following error on an unknown function: ``` - (line 64): No matches for wildcard '"mise-"*'. See `help wildcards-globbing`. if test "$argv[1]" != "mise" -a "$argv[1]" != "mise-"* ``` This has been replaced with a fish-specific implementation test that prevents the error and is somewhat more idiomatic as well.
jdx
pushed a commit
that referenced
this pull request
Jan 17, 2025
An error for `fish_command_not_found` was introduce in #4094 because glob misses do not work the same in fish as in other shells. As such, we are getting the following error on an unknown function: ``` - (line 64): No matches for wildcard '"mise-"*'. See `help wildcards-globbing`. if test "$argv[1]" != "mise" -a "$argv[1]" != "mise-"* ``` This has been replaced with a fish-specific implementation test that prevents the error and is somewhat more idiomatic as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This infinite loop bug is triggered when
miseitself becomes not found, e.g., by deleting the directorymiseis in.Here's some output of the shell with
set -xon when doingrm -rfon the directory (workspace/) containingmisein some subpath: