-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Table): 给个默认背景色,解决在飞书小程序中固定列与滚动内列混合 #2787
Conversation
Walkthrough此次更改主要涉及 Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2787 +/- ##
==========================================
- Coverage 84.07% 84.04% -0.04%
==========================================
Files 217 217
Lines 17830 17830
Branches 2609 2606 -3
==========================================
- Hits 14991 14985 -6
- Misses 2834 2840 +6
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/packages/table/table.scss (1)
77-78
: 建议使用 CSS 变量替代硬编码的颜色值这个修复解决了飞书小程序中固定列与滚动列混合的问题,代码逻辑正确。不过建议将背景色值改为使用 CSS 变量,以便于主题定制和维护。
建议按照以下方式修改:
- background-color: #fff; + background-color: var(--nut-table-fixed-bg-color, #fff);这样做的好处是:
- 保持与项目其他样式变量的一致性
- 方便后续主题定制
- 提高代码可维护性
🤔 这个变动的性质是?
🔗 相关 Issue
#2763
💡 需求背景和解决方案
在飞书小程序中使用Table固定列属性,固定列与滚动内列会混合,样式穿透
☑️ 请求合并前的自查清单
Summary by CodeRabbit