Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): 给个默认背景色,解决在飞书小程序中固定列与滚动内列混合 #2787

Closed
wants to merge 2 commits into from

Conversation

kid-kang
Copy link
Contributor

@kid-kang kid-kang commented Nov 22, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#2763

💡 需求背景和解决方案

在飞书小程序中使用Table固定列属性,固定列与滚动内列会混合,样式穿透

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新特性
    • 为粘性表头单元格添加默认背景颜色,以改善视觉效果。
  • 样式
    • 更新了固定列的粘性表头背景颜色,确保在特定环境下的可读性。

Copy link

coderabbitai bot commented Nov 22, 2024

Walkthrough

此次更改主要涉及 table.scss 文件,新增了 .nut-table 类中粘性表头单元格的默认背景颜色。具体来说,为具有 .nut-table-fixed-left.nut-table-fixed-right 类的 .nut-table-main-head-th 类引入了新的背景颜色属性。此更改旨在解决特定环境(称为“小程序”)中固定列与可滚动内列重叠的视觉问题。新的背景颜色设置为白色(#fff)。

Changes

文件路径 更改摘要
src/packages/table/table.scss .nut-table-main-head-th 类添加了新的背景颜色属性,仅在其具有 .nut-table-fixed-left.nut-table-fixed-right 类时生效。

Possibly related PRs

  • feat(table): table新增自定义行 #2390: 此PR为表格组件引入了自定义行的新特性,与主PR中增强表头视觉一致性的样式更改相关。
  • refactor: table #2473: 此PR重构了表格组件,包括可能与主PR中粘性表头样式调整相互影响的渲染逻辑更改。
  • fix(tag): modify svg color #2761: 此PR修改了标签组件中的SVG颜色,虽然与表格样式没有直接关系,但表明UI组件的持续调整可能会影响整体视觉一致性。

Suggested labels

3.x

Suggested reviewers

  • oasis-cloud

Poem

🐰 在表格中,头顶白色光,
粘性表头,视觉更强。
小程序里,重叠不见,
设计美好,兔子欢颜! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 2.x label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (d107304) to head (4d88a1f).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2787      +/-   ##
==========================================
- Coverage   84.07%   84.04%   -0.04%     
==========================================
  Files         217      217              
  Lines       17830    17830              
  Branches     2609     2606       -3     
==========================================
- Hits        14991    14985       -6     
- Misses       2834     2840       +6     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
src/packages/table/table.scss (1)

77-78: 建议使用 CSS 变量替代硬编码的颜色值

这个修复解决了飞书小程序中固定列与滚动列混合的问题,代码逻辑正确。不过建议将背景色值改为使用 CSS 变量,以便于主题定制和维护。

建议按照以下方式修改:

- background-color: #fff;
+ background-color: var(--nut-table-fixed-bg-color, #fff);

这样做的好处是:

  1. 保持与项目其他样式变量的一致性
  2. 方便后续主题定制
  3. 提高代码可维护性
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d107304 and 4d88a1f.

📒 Files selected for processing (1)
  • src/packages/table/table.scss (1 hunks)

@kid-kang kid-kang closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant