Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iankko
Copy link
Contributor

@iankko iankko commented Sep 20, 2018

Describe and add example values for the newly introduced SERVICE_WAIT_NAME,
SERVICE_WAIT_RETRY_MESSAGE, and SERVICE_WAIT_INTRO_MESSAGE environment
variables

Also move the description of SSO_ADMIN_USERNAME, SSO_ADMIN_PASSWORD,
SSO_SERVICE_USERNAME, and SSO_SERVICE_PASSWORD variables from image.yaml
to os-sso/module.yaml. These variables aren't used / referenced outside
of some of os-sso, os-sso71, and os-sso72 modules, and for the future
we want one common 'os-sso' module, sharing all the parts common to
all RH-SSO images. This move is part of such unification

Signed-off-by: Jan Lieskovsky [email protected]

Thanks for submitting your Pull Request!

Please make sure your PR meets following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull request does not include fixes for other issues than the main ticket
  • Attached commits represent unit of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <[email protected]> - use git commit -s

@iankko
Copy link
Contributor Author

iankko commented Sep 20, 2018

@rcernich @Crumby PTAL (once got a chance)

Thank you, Jan

@iankko iankko force-pushed the CLOUD-2453-launch-script branch 5 times, most recently from 0884814 to b478077 Compare September 24, 2018 10:54
@iankko iankko changed the title [CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine [WIP][DO NOT MERGE] [CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine Sep 24, 2018
@iankko iankko force-pushed the CLOUD-2453-launch-script branch 4 times, most recently from 13d60e0 to 77b3957 Compare October 10, 2018 11:07
@iankko iankko changed the title [WIP][DO NOT MERGE] [CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine [CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine Oct 10, 2018
Describe and add example values for the newly introduced SERVICE_WAIT_NAME,
SERVICE_WAIT_RETRY_MESSAGE, and SERVICE_WAIT_INTRO_MESSAGE environment
variables

Also move the description of SSO_ADMIN_USERNAME, SSO_ADMIN_PASSWORD,
SSO_SERVICE_USERNAME, and SSO_SERVICE_PASSWORD variables from image.yaml
to os-sso/module.yaml. These variables aren't used / referenced outside
of some of os-sso, os-sso71, and os-sso72 modules, and for the future
we want one common 'os-sso' module, sharing all the parts common to
all RH-SSO images. This move is part of such unification

Signed-off-by: Jan Lieskovsky <[email protected]>
@iankko iankko force-pushed the CLOUD-2453-launch-script branch from 166e783 to 6c8e0b5 Compare October 10, 2018 17:02
@iankko
Copy link
Contributor Author

iankko commented Oct 10, 2018

The PR was updated, and should be ready for re-review.

Copy link
Contributor

@rcernich rcernich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with these, but I have to say again that the paradigm is to let the pod cycle until the db becomes available (i.e. this isn't very cloudy, maybe it's sunshiny;)).

@iankko iankko changed the title [CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine [DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants