-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine #295
Open
iankko
wants to merge
1
commit into
jboss-openshift:master
Choose a base branch
from
iankko:CLOUD-2453-launch-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
iankko
force-pushed
the
CLOUD-2453-launch-script
branch
from
September 21, 2018 11:22
169e7fd
to
888ae59
Compare
Crumby
reviewed
Sep 21, 2018
iankko
force-pushed
the
CLOUD-2453-launch-script
branch
5 times, most recently
from
September 24, 2018 10:54
0884814
to
b478077
Compare
iankko
changed the title
[CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine
[WIP][DO NOT MERGE] [CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine
Sep 24, 2018
iankko
force-pushed
the
CLOUD-2453-launch-script
branch
4 times, most recently
from
October 10, 2018 11:07
13d60e0
to
77b3957
Compare
iankko
changed the title
[WIP][DO NOT MERGE] [CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine
[CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine
Oct 10, 2018
Describe and add example values for the newly introduced SERVICE_WAIT_NAME, SERVICE_WAIT_RETRY_MESSAGE, and SERVICE_WAIT_INTRO_MESSAGE environment variables Also move the description of SSO_ADMIN_USERNAME, SSO_ADMIN_PASSWORD, SSO_SERVICE_USERNAME, and SSO_SERVICE_PASSWORD variables from image.yaml to os-sso/module.yaml. These variables aren't used / referenced outside of some of os-sso, os-sso71, and os-sso72 modules, and for the future we want one common 'os-sso' module, sharing all the parts common to all RH-SSO images. This move is part of such unification Signed-off-by: Jan Lieskovsky <[email protected]>
iankko
force-pushed
the
CLOUD-2453-launch-script
branch
from
October 10, 2018 17:02
166e783
to
6c8e0b5
Compare
The PR was updated, and should be ready for re-review. |
rcernich
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with these, but I have to say again that the paradigm is to let the pod cycle until the db becomes available (i.e. this isn't very cloudy, maybe it's sunshiny;)).
iankko
changed the title
[CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine
[DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan Lieskovsky [email protected]
Thanks for submitting your Pull Request!
Please make sure your PR meets following requirements:
[CLOUD-XYA] Subject
CONTRIBUTING.md
)Signed-off-by: Your Name <[email protected]>
- usegit commit -s