fix: Replace iframe location instead of pushing to the history stack. #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svgomg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI! 👋
When using SVGOMG I notices that whenever I made a change to the compression settings, a new entry was being pushed to the history stack, essentially making it impossible to go back to the page that referred me to SVGOMG:
Bug investigation
I put a breakpoint in the event handler of one of the inputs, and eventually found the exact statement causing this problem. Essentially, changing an iframe's src attribute causes a new entry on top of the history stack. Using a slightly different API, the iframe's location can be replaced without adding onto the stack.
This PR
Introduces a fix that replaces the SVG iframe's location, instead of pushing a new entry to the history stack 💜