[v2][storage] Implement reverse adapter to translate v2 storage api to v1 #6485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6485 +/- ##
==========================================
+ Coverage 96.27% 96.31% +0.03%
==========================================
Files 370 371 +1
Lines 21169 21251 +82
==========================================
+ Hits 20380 20467 +87
+ Misses 604 600 -4
+ Partials 185 184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Jan 5, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
commented
Jan 5, 2025
| @@ -85,7 +85,7 @@ func parseResponse(t *testing.T, body []byte, obj gogoproto.Message) { | |||
| require.NoError(t, gogojsonpb.Unmarshal(bytes.NewBuffer(body), obj)) | |||
| } | |||
|
|
|||
| func makeTestTraceV2() ptrace.Traces { | |||
| func makeTestTrace() ptrace.Traces { | |||
There was a problem hiding this comment.
drive by change: i forgot to change the name of this function in a previous PR
mahadzaryab1
changed the title
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Jan 5, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
adityachopra29
pushed a commit
to adityachopra29/jaeger
that referenced
this pull request
Jan 9, 2025
…o v1 (jaegertracing#6485) ## Which problem is this PR solving? - Resolves jaegertracing#6480 ## Description of the changes - This PR implements a reverse adapter (`SpanReader`) that wraps a native v2 storage interface (`tracestore.Reader`) and downgrades it to implement the v1 storage interface (`spanstore.Reader`). - The reverse adapter was integrated with the v1 query service. This code path will only get executed once we start upgrading the existing storage implementations to implement the new `tracestore.Reader` interface as a part of jaegertracing#6458 ## How was this change tested? - CI - Added new unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: adityachopra29 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
SpanReader) that wraps a native v2 storage interface (tracestore.Reader) and downgrades it to implement the v1 storage interface (spanstore.Reader).tracestore.Readerinterface as a part of Upgrade Storage Backends to V2 Storage API #6458How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test