-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2114 (nulls in LodGenerator result) #2117
Conversation
Fixes 2114
Fixes #2114 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following unit tests are currently failing in this PR:
com.jme3.tools.LodGeneratorTest > testMonkeyReductionProportional
com.jme3.tools.LodGeneratorTest > testMonkeyReductionConstant
com.jme3.tools.LodGeneratorTest > testMonkeyReductionCollapsCost
This could mean that the tests need to be updated or that the PR introduces issues.
Build test failed because of 3 tests I made. Locale execution without gradle works, with gradle build it fails.
required: java.util.Map.Entry<java.lang.String,com.jme3.plugins.json.JsonElement>[] 320 tests completed, 3 failed, 1 skipped FAILURE: Build failed with an exception. |
@riccardobl I removed the Test decorator. I guess it is an issue with loading the Jaime.j3o asset while building. |
@riccardobl Do you support disabling the failing junit tests? |
@stephengold @riccardobl I added javadoc and the licenses. |
Apologies for the late reply, somehow i've missed the notifications. |
@riccardobl |
This patch fixes 2114 and adds simple tests.
Removes the check if some lod failed.
The performance gain is negligible, most of the time it copies <10 VertexBuffer refs unless I overlook something.