fix webui when detach list is empty

j-hc · Jan 1, 2025 · b8f7d3e · b8f7d3e
1 parent ba12e88
commit b8f7d3e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cli/src/main.rs b/cli/src/main.rs
@@ -118,6 +118,10 @@ fn main() -> ExitCode {
                     eprintln!("ERROR: package name not supplied.");
                     return ExitCode::FAILURE;
                 };
+                if pkg_name.is_empty() {
+                    eprintln!("ERROR: package name is empty.");
+                    return ExitCode::FAILURE;
+                }
                 if detach_by_name(&pkg_name).expect("detach.txt") {
                     println!("Changes are applied. No need for a reboot!");
                 } else {

diff --git a/ksu-webui/src/index.js b/ksu-webui/src/index.js
@@ -44,16 +44,15 @@ async function main() {
 
 	const detached_list_out = await run("/data/adb/modules/zygisk-detach/detach list");
 	if (detached_list_out === undefined) return;
-	const detached = detached_list_out.split('\n');
-	let uninstalled = [...detached];
+	const detached = detached_list_out ? detached_list_out.split('\n') : [];
+	const uninstalled = detached ? [...detached] : [];
 	for (const pkg of pkgs.split('\n').map((line) => line.split(':')[1])) {
 		const incls = detached.includes(pkg);
 		populateApp(pkg, incls);
 		if (incls) {
 			const index = uninstalled.indexOf(pkg);
 			if (index > -1) uninstalled.splice(index, 1);
 		}
-
 	}
 	for (const pkg of uninstalled) populateApp(pkg, true);
 	sortChecked();