-
Notifications
You must be signed in to change notification settings - Fork 44
546 boolean options flags #600
base: main
Are you sure you want to change the base?
Conversation
Hi @ykasimov! Approved PR run, and added you once again to the reviewers. You'll get notifications for PRs in this repo, but you are able now to approve yours :) |
Codecov ReportBase: 86.24% // Head: 86.24% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 86.24% 86.24%
=======================================
Files 107 107
Lines 9641 9641
=======================================
Hits 8315 8315
Misses 1326 1326
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@mike0sv is this ready to be merged? |
@ykasimov you still need to address the second part of my comment in the original issue Need to be careful though because we also might need to alter option name. Eg if is_on has default value False, it makes sense that --is_on will make it True. But if is_on default value is True, we should have something like --not_is_on as an option name Otherwise you either will not be able to change default value via CLI or it will be name for a flag. Also need some tests for this |
Fixes #546