Skip to content

Commit

Permalink
Merge pull request #13 from itepifanio/mypy
Browse files Browse the repository at this point in the history
Rollback ruff version to avoid nbqa warning. Add pre-commit
  • Loading branch information
itepifanio authored Mar 4, 2024
2 parents f9fddab + ac4eaf8 commit 59ced3b
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
18 changes: 18 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
repos:
- repo: local
hooks:
- id: run-lint
name: Run lint
entry: bash -c 'nbqa ruff --fix nbs/*.ipynb'
language: system
pass_filenames: false
- id: run-mypy
name: Run mypy
entry: bash -c 'nbqa mypy nbs/*.ipynb'
language: system
pass_filenames: false
- id: run-tests
name: Run Tests
entry: nbdev_test
language: system
pass_filenames: false
3 changes: 3 additions & 0 deletions mypy.ini
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
[mypy]
ignore_missing_imports = True

[mypy-path.jsonschema]
ignore_errors = True
2 changes: 1 addition & 1 deletion settings.ini
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ language = English
status = 3
user = itepifanio
requirements = ipykernel>=6.20.1
dev_requirements = solara>=1.26.1 nbqa>=1.8.3 ruff>=0.3.0 mypy>=1.8.0
dev_requirements = solara>=1.26.1 nbqa>=1.8.3 ruff<=0.2.2 mypy>=1.8.0 pre-commit
readme_nb = index.ipynb
allowed_metadata_keys =
allowed_cell_metadata_keys =
Expand Down

0 comments on commit 59ced3b

Please sign in to comment.