Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6256,#7220,#7519,#7545,#7546,irods/irods_resource_plugin_s3#2156] update externals (4-3-stable) #7527

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

@SwooshyCueb
Copy link
Member Author

Marked ready for review

@trel
Copy link
Member

trel commented Mar 2, 2024

seems good to my eye. value accordingly :)

korydraughn
korydraughn previously approved these changes Mar 4, 2024
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Pound it.

@SwooshyCueb
Copy link
Member Author

There was a suggested change in the main branch equivalent of this PR (#7526), so I'm pulling this back into draft mode to bring it to parity.

@SwooshyCueb SwooshyCueb marked this pull request as draft March 5, 2024 18:16
@SwooshyCueb SwooshyCueb force-pushed the libstdcxx.4-3-stable branch from 84b4804 to 83e2f5f Compare March 5, 2024 18:17
@SwooshyCueb SwooshyCueb changed the title [#6256,#7220,#7519,irods/irods_resource_plugin_s3#2156] update externals (4-3-stable) [#6256,#7220,#7519,#7545,#7546,irods/irods_resource_plugin_s3#2156] update externals (4-3-stable) Mar 5, 2024
@SwooshyCueb SwooshyCueb force-pushed the libstdcxx.4-3-stable branch from 83e2f5f to 3899253 Compare March 5, 2024 18:35
@korydraughn korydraughn dismissed their stale review March 5, 2024 19:33

No changes appeared.

@SwooshyCueb SwooshyCueb force-pushed the libstdcxx.4-3-stable branch 2 times, most recently from c2615b0 to 20e7e15 Compare March 5, 2024 20:22
@SwooshyCueb SwooshyCueb marked this pull request as ready for review March 5, 2024 20:22
@SwooshyCueb
Copy link
Member Author

Marked ready for review

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Let's get one more approval before squashing/pounding.

@SwooshyCueb SwooshyCueb force-pushed the libstdcxx.4-3-stable branch from 20e7e15 to eed6069 Compare March 5, 2024 20:35
CMakeLists.txt Outdated Show resolved Hide resolved
@SwooshyCueb SwooshyCueb force-pushed the libstdcxx.4-3-stable branch from eed6069 to ce64d3a Compare March 5, 2024 20:40
@trel
Copy link
Member

trel commented Mar 5, 2024

good here.

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pound it.

@SwooshyCueb SwooshyCueb force-pushed the libstdcxx.4-3-stable branch from ce64d3a to c4ca5b9 Compare March 5, 2024 22:48
@SwooshyCueb
Copy link
Member Author

#'d

@alanking alanking merged commit b8ab5c2 into irods:4-3-stable Mar 6, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants