Move to AL2023 #29
Open
Move to AL2023 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to move to AL2023.
Main difference is the required format of the user-data. The NodeConfig yaml object is now required and kubelet is started automatically as a result of this.
Other notable change is that additional interfaces are now added after the K8s node is ready.
Examples have all been modified to work for AL2023.
Note that there is a change to the API: now
kubelet_extra_argsmust be specified as a list of args, instead of a single string. The reviewer should consider if this change is acceptable. If not, it should be possible to instead keep the API the same and parse the space-separated string into a list ourselves.Testing:
kubelet_extra_args