Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Whole Project Structure #1

Merged
merged 12 commits into from
Jan 10, 2025

Conversation

OS-ricardomoreirasilva
Copy link
Contributor

@OS-ricardomoreirasilva OS-ricardomoreirasilva commented Jan 8, 2025

Besides the library implementation migrated from the mono repo, the PR adds the workflows + the README file.

The Continuous Integration workflow is missing the SonarCloud steps. These will be added in the future.
@OS-ricardomoreirasilva OS-ricardomoreirasilva self-assigned this Jan 8, 2025
@OS-ricardomoreirasilva OS-ricardomoreirasilva force-pushed the chore/merge-monorepo-files branch 2 times, most recently from 2f4cef3 to f9b09a2 Compare January 8, 2025 16:32
SLACK_WEBHOOK should not be used by any pipeline.
@OS-ricardomoreirasilva OS-ricardomoreirasilva marked this pull request as draft January 9, 2025 10:56
@OS-ricardomoreirasilva OS-ricardomoreirasilva marked this pull request as ready for review January 9, 2025 10:59
.github/workflows/continuous_integration.yml Outdated Show resolved Hide resolved
OSGeolocationLib.podspec Outdated Show resolved Hide resolved
.github/workflows/continuous_integration.yml Show resolved Hide resolved
.github/workflows/prepare_release.yml Show resolved Hide resolved
.github/workflows/prepare_release.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
This was required by SonarCloud, that has been removed as well in the meantime.
Provide the actual information for the library.
Update the Cordova and Capacitor plugins' links.
Move this section closer to the top.
Set all the remaining versions to the initial 0.0.1 value.
@alexgerardojacinto
Copy link

@OS-ricardomoreirasilva the "Continuous Integration" workflow seems to be failing. Is this expected?

@OS-ricardomoreirasilva OS-ricardomoreirasilva force-pushed the chore/merge-monorepo-files branch 2 times, most recently from 497c7ee to 8dc2dce Compare January 10, 2025 13:21
@OS-ricardomoreirasilva
Copy link
Contributor Author

OS-ricardomoreirasilva commented Jan 10, 2025

@OS-ricardomoreirasilva the "Continuous Integration" workflow seems to be failing. Is this expected?

If you check the commit history, you'll see that it started to happen after a README update. 🤣
The error is related to the GitHub Actions runner image, as there was an update 2 days ago. It looks like there isn't much we can do, unfortunately.

Update: I've found a way to workaround the issue.

@OS-ricardomoreirasilva OS-ricardomoreirasilva force-pushed the chore/merge-monorepo-files branch 3 times, most recently from 1612e36 to 8dc2dce Compare January 10, 2025 13:37
@OS-ricardomoreirasilva OS-ricardomoreirasilva merged commit aefe871 into main Jan 10, 2025
1 check passed
@OS-ricardomoreirasilva OS-ricardomoreirasilva deleted the chore/merge-monorepo-files branch January 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants