Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove melos.yaml in favor of the root pubspec.yaml #832

Merged
merged 12 commits into from
Jan 10, 2025

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Jan 9, 2025

Description

Since we now declare the packages in the workspace section in the pubspec.yaml file we'll move the rest of the config in there too, under it's own melos section. This is common practice for other dart tools too and the Dart team knows about it.

Continues on the #747 effort.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Jan 9, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~832

Documentation is deployed and generated using docs.page.

@spydon spydon mentioned this pull request Jan 9, 2025
7 tasks
<!--
  Thanks for contributing!

Provide a description of your changes below and a general summary in the
title

Please look at the following checklist to ensure that your PR can be
accepted quickly:
-->

## Description

Since pub workspaces now can run analyze within all packages in the
workspace we can now remove our analyze proxy command.

Closes: #827 

## Type of Change

<!--- Put an `x` in all the boxes that apply: -->

- [ ] ✨ `feat` -- New feature (non-breaking change which adds
functionality)
- [x] 🛠️ `fix` -- Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ `!` -- Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] 🧹 `refactor` -- Code refactor
- [ ] ✅ `ci` -- Build configuration change
- [ ] 📝 `docs` -- Documentation
- [ ] 🗑️ `chore` -- Chore
@ricardodalarme
Copy link

ricardodalarme commented Jan 9, 2025

For some reason I cannot import this version of Melos into my repo:

Error on line 1, column 7: "name" field doesn't match expected name "melos".
  ╷
1 │ name: melos_workspace
  │       ^^^^^^^^^^^^^^^
  ╵
exit code 65

note: the name of my workspace is monorepo.

@spydon
Copy link
Collaborator Author

spydon commented Jan 9, 2025

For some reason I cannot import this version of Melos into my repo:

Error on line 1, column 7: "name" field doesn't match expected name "melos".
  ╷
1 │ name: melos_workspace
  │       ^^^^^^^^^^^^^^^
  ╵
exit code 65

note: the name of my workspace is monorepo.

Interesting, what do you have in your root pubspec.yaml?

@ricardodalarme
Copy link

Oh, it was actually a typo in the path, I've just updated it and it works fine now. Srr

@spydon spydon requested a review from exaby73 January 9, 2025 23:23
@spydon spydon merged commit ade758c into main Jan 10, 2025
11 checks passed
@spydon spydon deleted the feat/remove-melos.yaml branch January 10, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants