Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: too many open files while creating a workspace #804

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

mahmuttaskiran
Copy link
Contributor

Description

Fixing #803

I was thinking of creating a new Future extension to handle parallelism, but then I discovered that Stream.parallel already does the job by using the number of processors for concurrency. It turned out to be a perfect fit for what I needed

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Dec 14, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~804

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your contribution!

@spydon spydon enabled auto-merge (squash) December 16, 2024 13:55
@mahmuttaskiran
Copy link
Contributor Author

Hey @spydon, the CI workflows are on hold for some reason

@spydon
Copy link
Collaborator

spydon commented Dec 17, 2024

Hey @spydon, the CI workflows are on hold for some reason

Ah, it was because of the rebase and that you haven't contributed before. Started them now. :)

auto-merge was automatically disabled December 17, 2024 12:17

Head branch was pushed to by a user without write access

@mahmuttaskiran mahmuttaskiran force-pushed the fix/too-many-open-files branch from eb92fe4 to ff85492 Compare December 17, 2024 12:17
@mahmuttaskiran
Copy link
Contributor Author

There are some tests failing which I couldn't relate with changes introduced with this PR

@spydon
Copy link
Collaborator

spydon commented Dec 18, 2024

It's the new Flutter version that breaks the tests, as can be seen here: #806
There are most likely just some expected output strings that have changed.

@mahmuttaskiran
Copy link
Contributor Author

It's the new Flutter version that breaks the tests, as can be seen here: #806 There are most likely just some expected output strings that have changed.

I plan to update tests this weekend. Thank you!

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@spydon spydon merged commit db82281 into invertase:main Jan 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants