This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Update Plugin RDT to supported level #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/medium_test.cpp
Outdated
| @@ -336,25 +336,29 @@ void test_collected_metrics_content(PQOSMock *p_mock, pqos_cap *p_cap, unsigned | |||
| // Start collecting all metrics | |||
| rdt::Collector *rdt = new rdt::Collector(p_mock); | |||
| auto metrics = fixture_metrics(num_cores); | |||
| EXPECT_NO_THROW(rdt->collect_metrics(metrics)); | |||
| auto mts = rdt->collect_metrics(metrics); | |||
| // /EXPECT_NO_THROW(rdt->collect_metrics(metrics)); | |||
MrDarthShoe
force-pushed
the
rdt-supporting
branch
from
d390053 to
cab8bc6
Compare
MrDarthShoe
force-pushed
the
rdt-supporting
branch
11 times, most recently
from
2206536 to
593c099
Compare
work in progress- testing
MrDarthShoe
force-pushed
the
rdt-supporting
branch
2 times, most recently
from
a7e487a to
352e2d8
Compare
MrDarthShoe
force-pushed
the
rdt-supporting
branch
from
352e2d8 to
3ff254f
Compare
|
Here is link for easier review: https://reviewable.io/reviews/intelsdi-x/snap-plugin-collector-rdt/17#- |
| RUN yum install -y git cmake mc tmux autoconf automake libtool curl make unzip wget clang gcc-c++ | ||
| FROM ubuntu:xenial | ||
|
|
||
| RUN apt-get update && apt-get upgrade -yq |
There was a problem hiding this comment.
remove double spaces
| { | ||
| auto metric_ns = extract_ns(metrics[i]); | ||
| std::string metric_ns = "/"; | ||
| metric_ns += mts[i].ns().get_string(); |
There was a problem hiding this comment.
Leading namespace by separator should happen in get_string(), not outside. I submitted an issue to address this change in snap-plugin-lib-cpp - intelsdi-x/snap-plugin-lib-cpp#66. Until it's not resolved in plugin-lib side, it might stay as it is in collector tests.
| sudo yum install -y git cmake mc tmux autoconf automake libtool curl make unzip wget clang gcc-c++ | ||
| cd snap-plugin-collector-rdt | ||
| sudo apt-get update && sudo apt-get upgrade -yq | ||
| sudo apt-get install g++-4.9 gcc-4.9 protobuf-compiler libprotobuf-dev libprotoc-dev libboost-dev libcppnetlib-dev libspdlog-dev git curl cmake golang-go autoconf libtool ca-certificates unzip software-properties-common golang-go -yq |
There was a problem hiding this comment.
golang-go two times
| FROM ubuntu:xenial | ||
|
|
||
| RUN apt-get update && apt-get upgrade -yq | ||
| RUN apt-get install g++-4.9 gcc-4.9 protobuf-compiler libprotobuf-dev libprotoc-dev libboost-dev libcppnetlib-dev libspdlog-dev git curl cmake golang-go autoconf libtool ca-certificates unzip software-properties-common golang-go -yq |
There was a problem hiding this comment.
golang-go two times
|
The Travis's outcome seems to be false-positive - there is an error: What is more, I cannot build it (executing It seems that the procedure of installing GTest does not work as expected. |
|
:( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated collector to newest version of snap-plugin-lib-cpp
This change is