-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
put table first #266
put table first #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks Pawel!
what do you think of renaming the "Introduction" to "how to use this catalog" ? @pawelru |
Unit Tests Summary340 tests 252 ✅ 1m 2s ⏱️ Results for commit 75749e4. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit a3be6ec ♻️ This comment has been updated with latest results. |
I have no strong opinion. Either of those looks good to me |
an attempt to fix #265
currently one table only but if this is ok I can go for other tables as well
Changes:
session_info::session_info()
for better readability