Fix label and indentation processors #1379
Draft
+115
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Summary 1 files 84 suites 1m 22s ⏱️ Results for commit a2f3a8b. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 3765fef ♻️ This comment has been updated with latest results. |
shajoezhu
reviewed
Jan 22, 2025
Melkiades
reviewed
Jan 22, 2025
| if (is.null(row_nms)) { # One row per statistic | ||
| common_names <- intersect(names(out), names(indents_in)) | ||
| out[common_names] <- indents_in[common_names] | ||
| } else if (!is.null(row_nms)) { # One row per combination of variable level and statistic |
There was a problem hiding this comment.
I think it would be better to merge behavior with .adjust_stats_desc_by_in_def (we can definitely pick a better name ahah)
There was a problem hiding this comment.
This is something to do for formats and indentation. Are the count cases that provide counts for each level for each stats (I think keeping this structure clear with the stat name on top is the best)
Melkiades
reviewed
Jan 23, 2025
|
|
||
| out | ||
| out %>% unlist() |
There was a problem hiding this comment.
maybe we want the other .unlist_keep*?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #1378 #1363