Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests, implement testthat 3rd edition #59

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Fix integration tests, implement testthat 3rd edition #59

merged 1 commit into from
Dec 9, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Dec 8, 2023

Pull Request

Fixes #58

@edelarua edelarua added the sme label Dec 8, 2023
@edelarua edelarua enabled auto-merge (squash) December 8, 2023 23:21
@edelarua edelarua disabled auto-merge December 8, 2023 23:21
@edelarua edelarua enabled auto-merge (squash) December 8, 2023 23:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ---------
R/tabulate_rbmi.R       82       0  100.00%
TOTAL                   82       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a407f29

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Unit Tests Summary

7 tests   6 ✔️  0s ⏱️
3 suites  1 💤
1 files    0 ❌

Results for commit a407f29.

shajoezhu
shajoezhu approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @edelarua

@edelarua edelarua merged commit a687fcd into main Dec 9, 2023
24 checks passed
@edelarua edelarua deleted the 58_fix_tests@main branch December 9, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration tests
2 participants
@edelarua @shajoezhu