Skip to content

Commit

Permalink
1176 remove Show Warnings from modules (#264)
Browse files Browse the repository at this point in the history
Part of insightsengineering/teal#1176

---------

Signed-off-by: kartikeya kirar <[email protected]>
Signed-off-by: Marcin <[email protected]>
Co-authored-by: unknown <[email protected]>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
4 people authored May 10, 2024
1 parent 3a2c269 commit 1d5f0d2
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 72 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# teal.osprey 0.1.16.9017

* Removed `Show Warnings` modals from modules.

### Breaking Changes
* Adapted all modules to use `teal_data` objects.

Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_ae_oview.R
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ ui_g_ae_oview <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
)
)
Expand Down Expand Up @@ -333,13 +332,6 @@ srv_g_ae_oview <- function(id,

plot_r <- reactive(output_q()[["plot"]])

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
verbatim_content = reactive(teal.code::get_code(output_q())),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_ae_sub.R
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ ui_g_ae_sub <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
)
)
Expand Down Expand Up @@ -374,13 +373,6 @@ srv_g_ae_sub <- function(id,

plot_r <- reactive(output_q()[["plot"]])

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
verbatim_content = reactive(teal.code::get_code(output_q())),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_butterfly.R
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ ui_g_butterfly <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
),
pre_output = a$pre_output,
Expand Down Expand Up @@ -504,13 +503,6 @@ srv_g_butterfly <- function(id, data, filter_panel_api, reporter, dataname, labe
width = plot_width
)

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
title = paste("R code for", label),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_events_term_id.R
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ ui_g_events_term_id <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
)
)
Expand Down Expand Up @@ -364,13 +363,6 @@ srv_g_events_term_id <- function(id,

plot_r <- reactive(output_q()[["plot"]])

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
title = paste("R code for", label),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_heat_bygrade.R
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ ui_g_heatmap_bygrade <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
)
)
Expand Down Expand Up @@ -457,13 +456,6 @@ srv_g_heatmap_bygrade <- function(id,

plot_r <- reactive(output_q()[["plot"]])

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
title = paste("R code for", label),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_patient_profile.R
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ ui_g_patient_profile <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
),
pre_output = a$pre_output,
Expand Down Expand Up @@ -897,13 +896,6 @@ srv_g_patient_profile <- function(id,
width = plot_width
)

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
title = paste("R code for", label),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_spiderplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ ui_g_spider <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
),
pre_output = a$pre_output,
Expand Down Expand Up @@ -420,13 +419,6 @@ srv_g_spider <- function(id, data, filter_panel_api, reporter, dataname, label,
width = plot_width
)

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
title = paste("R code for", label),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_swimlane.R
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ ui_g_swimlane <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
),
pre_output = a$pre_output,
Expand Down Expand Up @@ -517,13 +516,6 @@ srv_g_swimlane <- function(id,
width = plot_width
)

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

teal.widgets::verbatim_popup_srv(
id = "rcode",
title = paste("R code for", label),
Expand Down
8 changes: 0 additions & 8 deletions R/tm_g_waterfall.R
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ ui_g_waterfall <- function(id, ...) {
)
),
forms = tagList(
teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
),
pre_output = a$pre_output,
Expand Down Expand Up @@ -541,13 +540,6 @@ srv_g_waterfall <- function(id,
width = plot_width
)

teal.widgets::verbatim_popup_srv(
id = "warning",
verbatim_content = reactive(teal.code::get_warnings(output_q())),
title = "Warning",
disabled = reactive(is.null(teal.code::get_warnings(output_q())))
)

# Show R Code
teal.widgets::verbatim_popup_srv(
id = "rcode",
Expand Down

0 comments on commit 1d5f0d2

Please sign in to comment.