-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix early dev app #132
Fix early dev app #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vedhav
Should be re-deployed in ~10 mins to test. Can be tested in the same link: https://genentech.shinyapps.io/nest_early-dev_dev |
# optional libraries | ||
library(sparkline) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies that I jumped into the already closed PR
may I ask: why this particular change?
AFAIK sparkline is a supplementary module package - it's not required for data loading part (as opposed to dplyr
, scda
etc. which are correct here in this context). Therefore I would expect it to be at the beggining of the app.R script and not inside within()
.
(same for safety/app.R)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a misconception about this package. I remember that some app had error/warning when this library was not loaded. I think we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that loading this library would improve the variable browser module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. It's needed for the variable browser. I got the same understanding. But the position is quite unusual now because you moved the library into the teal_data(...) %>% within(<here>)
and usually we have modules libs load outside of this at the top of the script.
Fixes the error reported here
Changes:
join_keys
so the filter panel provides the valid data to the modules.