add design doc to align on MCMC options enhancements #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
gowerc
reviewed
Jan 21, 2025
gowerc
reviewed
Jan 21, 2025
gowerc
reviewed
Jan 21, 2025
gowerc
reviewed
Jan 21, 2025
luwidmer
reviewed
Jan 23, 2025
| We note that due to the definition of the prior distribution for the covariance matrix, we still need to fit the frequentist MMRM model in any case to get the required prior parameter. | ||
|
|
||
| Question: What do we need to adapt downstream when using multiple chains? | ||
| Answer: We will be able to test this in detail and address it, once we have implemented the possibility to use multiple chains in the development version. To avoid possible confusion, we can add a warning in the development version, which informs the user that multiple chains are not yet fully supported, while we are still working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gowerc and team,
please find inside a design doc to start alignment on MCMC options improvements. Thoughts/comments/concerns?
Thank you,
Daniel