Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for blank data_ice #461

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Add unit test for blank data_ice #461

merged 2 commits into from
Dec 9, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Dec 9, 2024

Closes #460

Adding unit test to prevent future regressions of issues where a blank data_ice object is provided.

Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things @gowerc

tests/testthat/test-longData.R Outdated Show resolved Hide resolved
tests/testthat/test-longData.R Show resolved Hide resolved
Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @gowerc !

@gowerc gowerc merged commit 5e651e4 into main Dec 9, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intended behavior when data_ice has no rows
2 participants