Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensionality control for data testing #309

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Jul 18, 2024

Fixes #303

@Melkiades Melkiades added enhancement New feature or request sme labels Jul 18, 2024
Copy link
Contributor

github-actions bot commented Jul 18, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

R/utils.R Show resolved Hide resolved
@Melkiades
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Melkiades Melkiades marked this pull request as ready for review July 18, 2024 09:39
Copy link
Contributor

github-actions bot commented Jul 18, 2024

Unit Tests Summary

  1 files    5 suites   29s ⏱️
 67 tests  45 ✅ 21 💤 0 ❌ 1 🔥
127 runs  105 ✅ 21 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit ca863df.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
utils_dim_control_and_checks 👶 $+0.31$ $+21$ $0$ $0$ $+1$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
utils_dim_control_and_checks 👶 $+0.02$ Checking_that_levels_are_reduced_correctly_for_multiple_variables_with_defaults
utils_dim_control_and_checks 👶 $+0.01$ describe_cols_df_works
utils_dim_control_and_checks 👶 $+0.06$ reduce_num_levels_in_df_add_specific_value_works
utils_dim_control_and_checks 👶 $+0.18$ reduce_num_levels_in_df_explorative_TRUE_Plots_are_returned
utils_dim_control_and_checks 👶 $+0.02$ reduce_num_levels_in_df_num_max_values_num_of_rare_values_works
utils_dim_control_and_checks 👶 $+0.02$ reduce_num_levels_in_df_num_max_values_works

Results for commit 2b00d10

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename                            Stmts    Miss  Cover    Missing
--------------------------------  -------  ------  -------  ----------------------------------------------
R/radab.R                             284       1  99.65%   390
R/radae.R                             198       3  98.48%   76, 95, 284
R/radaette.R                          203       4  98.03%   50, 72, 78, 260
R/radcm.R                             150       2  98.67%   51, 204
R/raddv.R                              91       2  97.80%   54, 137
R/radeg.R                             266       1  99.62%   366
R/radex.R                             229       1  99.56%   320
R/radhy.R                             136       1  99.26%   198
R/radlb.R                             334       1  99.70%   426
R/radmh.R                              93       2  97.85%   45, 134
R/radpc.R                              85       1  98.82%   125
R/radpp.R                              83       1  98.80%   153
R/radqlqc.R                          1024       7  99.32%   331, 820, 1112-1116
R/radqs.R                             118       1  99.15%   185
R/radrs.R                             122       3  97.54%   47, 54, 183
R/radsaftte.R                           1       0  100.00%
R/radsl.R                             180       1  99.44%   260
R/radsub.R                            140       2  98.57%   171, 235
R/radtr.R                             124       0  100.00%
R/radtte.R                            208       4  98.08%   52, 72, 84, 279
R/radvs.R                             178       1  99.44%   251
R/utils_dim_control_and_checks.R      120      33  72.50%   105-114, 118-141, 163
R/utils.R                             158      15  90.51%   23, 100, 112, 116, 146-152, 365, 465, 474, 477
TOTAL                                4525      87  98.08%

Diff against main

Filename                            Stmts    Miss  Cover
--------------------------------  -------  ------  -------
R/utils_dim_control_and_checks.R     +120     +33  +72.50%
R/utils.R                              +2      +1  -0.52%
TOTAL                                +122     +34  -0.72%

Results for commit: 5cc29cd

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reduce_levels as a helper function
1 participant