Skip to content

Commit

Permalink
Merge commit '4055dd80097d2474492c8ef428f7ae58d657b752'
Browse files Browse the repository at this point in the history
  • Loading branch information
ddsjoberg committed Feb 26, 2024
2 parents 6f6e1ca + 4055dd8 commit ee1bd2e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 15 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ on:
workflow_dispatch:

jobs:
build:
name: Build package 🎁
needs: release
uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main
secrets:
REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }}
with:
skip-r-cmd-check: true
skip-r-cmd-install: true
docs:
name: Pkgdown Docs 📚
needs: release
Expand Down Expand Up @@ -53,6 +44,7 @@ jobs:
checking examples .* NOTE
checking Rd line widths .* NOTE
checking top-level files .* NOTE
skip-r-cmd-install: true
coverage:
name: Coverage 📔
needs: [release, docs]
Expand Down
9 changes: 6 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@

## Additional Comments

* This is a new release.
* This is a re-submission of a new release.

* Thank you for the review comments.
- Unexported functions no longer have examples.
- The `installed.packages()` function has been removed/replaced.
- References to software names and APIs in the DESCRIPTION have been removed to highlight other package functionality, therefore, no need to quote them.

* There are no additional references describing the methods in this package.

* I have created documentation Rd files for many non-exported functions and included examples for these unexported functions. This is a collaborative project, and the documentation is incredibly helpful to on-board new collaborators and help them understand the internal workings of the package. I've read through the R Packages manual and I do not believe there is a specific rule against this, but have heard reports of comments requesting that they are removed. If I can keep the documentation as it is, I would be much appreciative. Thank you!

* Thank you for your time!
3 changes: 0 additions & 3 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,3 @@ tidyselect
tidyselector
tidyselectors
univariable
unlist
unnested
unnests

0 comments on commit ee1bd2e

Please sign in to comment.