Skip to content

Commit

Permalink
(WIP) Re-enable Windows unicode tests (and TODO: fix them)
Browse files Browse the repository at this point in the history
  • Loading branch information
dbarnett committed Aug 24, 2024
1 parent 6dbb9ac commit 0a03efd
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Tests (tox)

on:
push:
branches: [master]
branches: [master, win32_unicode]
pull_request:
branches: [master]

Expand All @@ -18,13 +18,8 @@ jobs:
matrix:
py:
- "3.12"
- "3.11"
- "3.10"
- "3.9"
- "3.8"
os:
- ubuntu-latest
- macos-latest
- windows-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion gcalcli/gcal.py
Original file line number Diff line number Diff line change
Expand Up @@ -1571,7 +1571,7 @@ def CreateEventFromVOBJ(ve):

while True:
try:
v = next(vobject.readComponents(f))
v = next(vobject.readComponents(f, ignoreUnreadable=True))
except StopIteration:
break

Expand Down
4 changes: 0 additions & 4 deletions tests/test_gcalcli.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from json import load
import re

import pytest
from dateutil.tz import tzutc

from gcalcli.argparsers import (
Expand Down Expand Up @@ -274,9 +273,6 @@ def test_modify_event(PatchedGCalI):
gcal._edit_event, opts.text, opts.start, opts.end) == 0


@pytest.mark.skipif(
os.name == 'nt',
reason='Known unicode encode/decode issue, see insanum/gcalcli#387.')
def test_import(PatchedGCalI):
cal_names = parse_cal_names(['[email protected]'])
gcal = PatchedGCalI(cal_names=cal_names, default_reminders=True)
Expand Down

0 comments on commit 0a03efd

Please sign in to comment.