Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on data collected in https://github.com/elops/einarc_adaptec_tester
I found that for Adaptec controllers only reliable way to establish co-relation
between logical and physical is disk serial number.
logical listing (ld) is formated like
Type 1 (key here is Enclosure,Slot possilby controller if one has multiple)
Type 2 (key here is Channel,Device possibly Controller if one has multiple)
Type 3 (key here is Connector,Device possibly Controller if one has multiple)
Type 4 (numbers in brackets are Device,Channel)
physical listing (pd) only consistent representation for each disk is line like this
...
Problem is sometimes ld output maps to pd output; sometimes it does not (in case of ld type1, type3)
so to resolve mapping this fix uses disk serial to establish co-relation.