-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] l10n_ar_ux: Recompute the commercial partner for edit de contact form in portal #850
Conversation
570c92c
to
2aa745d
Compare
2aa745d
to
2a85ab9
Compare
05f00ea
to
b7a3f84
Compare
b7a3f84
to
95a983e
Compare
95a983e
to
2703083
Compare
66c4097
to
77ed97d
Compare
77ed97d
to
f6e568a
Compare
f6e568a
to
9e5d2bf
Compare
b5ef329
to
051681d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Varias cositas a revisar:
- evitar casteo en vista
- que el preparar values sea solo para los campos argentinos
- tema de confusion con respecto a como muestra los campos cuando hay errores.
- tema indentación. habías dejado un par de tabs, ver que este bien
- lineas en blanco agregas y eliminadas, remover y dejar solo los cambios reales y necesarios
18cca23
to
2134ca4
Compare
9b34613
to
a18d2a5
Compare
7c72a97
to
255055a
Compare
255055a
to
cb93c4d
Compare
cb93c4d
to
fa39124
Compare
68a04cb
to
332e830
Compare
332e830
to
f4b4e25
Compare
NOTA: Segun hablado con Maxi en slack ya esta modificado y probado el PR. procedemos a hacer rebase porque esta out of date y a mezclar |
…t form in portal Ticekt: 73707
f4b4e25
to
4578610
Compare
@roboadhoc r+ |
…t form in portal closes #850 Ticekt: 73707 Signed-off-by: Katherine Zaoral <[email protected]>
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
10 similar comments
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed): |
Ticekt: 73707