Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_ar_ux: Recompute the commercial partner for edit de contact form in portal #850

Closed
wants to merge 1 commit into from

Conversation

mem-adhoc
Copy link
Contributor

Ticekt: 73707

@roboadhoc
Copy link

@roboadhoc roboadhoc force-pushed the 16.0-t-73707-mem branch 2 times, most recently from 05f00ea to b7a3f84 Compare May 31, 2024 15:59
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/views/portal_templates.xml Outdated Show resolved Hide resolved
l10n_ar_ux/views/portal_templates.xml Outdated Show resolved Hide resolved
@roboadhoc roboadhoc force-pushed the 16.0-t-73707-mem branch 2 times, most recently from 66c4097 to 77ed97d Compare July 23, 2024 21:04
l10n_ar_ux/controllers/portal.py Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/views/portal_templates.xml Outdated Show resolved Hide resolved
l10n_ar_ux/views/portal_templates.xml Outdated Show resolved Hide resolved
@roboadhoc roboadhoc force-pushed the 16.0-t-73707-mem branch 2 times, most recently from b5ef329 to 051681d Compare July 29, 2024 18:32
Copy link
Contributor

@zaoral zaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mem-adhoc

Varias cositas a revisar:

  • evitar casteo en vista
  • que el preparar values sea solo para los campos argentinos
  • tema de confusion con respecto a como muestra los campos cuando hay errores.
  • tema indentación. habías dejado un par de tabs, ver que este bien
  • lineas en blanco agregas y eliminadas, remover y dejar solo los cambios reales y necesarios

@mem-adhoc mem-adhoc force-pushed the 16.0-t-73707-mem branch 2 times, most recently from 18cca23 to 2134ca4 Compare August 20, 2024 13:10
@roboadhoc roboadhoc force-pushed the 16.0-t-73707-mem branch 2 times, most recently from 9b34613 to a18d2a5 Compare August 20, 2024 17:07
@mem-adhoc mem-adhoc force-pushed the 16.0-t-73707-mem branch 2 times, most recently from 7c72a97 to 255055a Compare August 20, 2024 17:31
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
@mem-adhoc mem-adhoc force-pushed the 16.0-t-73707-mem branch 4 times, most recently from 68a04cb to 332e830 Compare October 21, 2024 14:25
@zaoral
Copy link
Contributor

zaoral commented Oct 21, 2024

NOTA: Segun hablado con Maxi en slack ya esta modificado y probado el PR. procedemos a hacer rebase porque esta out of date y a mezclar

l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
l10n_ar_ux/controllers/portal.py Outdated Show resolved Hide resolved
@zaoral
Copy link
Contributor

zaoral commented Oct 21, 2024

@roboadhoc r+

roboadhoc pushed a commit that referenced this pull request Oct 21, 2024
…t form in portal

closes #850

Ticekt: 73707
Signed-off-by: Katherine Zaoral <[email protected]>
@roboadhoc roboadhoc closed this Oct 21, 2024
@zaoral zaoral deleted the 16.0-t-73707-mem branch October 21, 2024 20:31
@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

10 similar comments
@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants