Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code/app): Add persistence to the example app #746

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

romac
Copy link
Member

@romac romac commented Jan 9, 2025

Closes: #740


PR author checklist

For all contributors

For external contributors

@romac romac marked this pull request as ready for review January 9, 2025 21:13
@romac romac merged commit e8438b4 into main Jan 9, 2025
11 checks passed
@romac romac deleted the romac/example-app-persistence branch January 9, 2025 21:22
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.28%. Comparing base (b3a7a67) to head (6c05791).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
code/crates/core-types/src/proposal.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   79.50%   79.28%   -0.21%     
==========================================
  Files         104      104              
  Lines        9023     9026       +3     
==========================================
- Hits         7173     7156      -17     
- Misses       1850     1870      +20     
Flag Coverage Δ
integration 78.99% <40.00%> (-0.50%) ⬇️
mbt 20.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(code/example): Add persistence to the example app
1 participant