-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: MBT for votekeeper #63
Conversation
@rnbguy Any chance we can make the MBT tests count towards code coverage? Apparently we can just upload multiple coverage reports and Codecov will merge them, which is pretty neat :) |
Or is that the case already? I see that the coverage job now sets the If so, then I am not sure I understand why we need the MBT workflow? |
You're right. we don't need the MBT workflow anymore - as MBT tests are already executed with Rust workflow and again in coverage workflow. |
Since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, guys ! 🎉
Just one last nit. Since the rust MBT tests now generate traces, fixing and executing them on the fly, maybe some of the Scripts are redundant. Feel free to remove them accordingly before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work guys, thanks so much! 🚀
Closes #44
Depends on #18 and #40.Also depends on #73.This PR adds a CI workflow
.github/workflows/mbt.yml
that generates trace files fromvoteBookkeeperTest.qnt
and then executes each trace in the code as a unit test. In particular:voteBookkeeperSM
for the parameterized state machine for the vote keeper.VotekeeperRunner
that builds the initial state and the steps from an ITF trace.