Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Events and SM improvements #19

Merged
merged 11 commits into from
Nov 7, 2023
Merged

code: Events and SM improvements #19

merged 11 commits into from
Nov 7, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 25, 2023 •
edited
Loading

Closes: #19

@adizere adizere changed the title CI week code: Events and SM improvements Oct 28, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

Merging #19 (361824c) into romac/rust-state-machine (828f7af) will increase coverage by 1.00%.
The diff coverage is 75.36%.

@@                     Coverage Diff                      @@
##           romac/rust-state-machine      #19      +/-   ##
============================================================
+ Coverage                     85.21%   86.21%   +1.00%     
============================================================
  Files                            20       20              
  Lines                          1028     1037       +9     
============================================================
+ Hits                            876      894      +18     
+ Misses                          152      143       -9
Files Coverage Δ
Code/common/src/round.rs 98.00% <ø> (+6.00%) ⬆️
Code/round/src/events.rs 0.00% <ø> (ø)
Code/round/src/state.rs 100.00% <100.00%> (+1.59%) ⬆️
Code/vote/src/keeper.rs 69.57% <100.00%> (+2.90%) ⬆️
Code/consensus/src/executor.rs 86.71% <90.00%> (+0.13%) ⬆️
Code/round/src/state_machine.rs 71.74% <65.91%> (+4.50%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

romac
romac commented Nov 3, 2023
View reviewed changes
Code/consensus/src/executor.rs Outdated Show resolved Hide resolved
@ancazamfir ancazamfir marked this pull request as ready for review November 4, 2023 00:24
@romac romac merged commit f53355f into romac/rust-state-machine Nov 7, 2023
6 of 7 checks passed
@romac romac deleted the retreat/ci-week branch November 7, 2023 10:50
@romac romac mentioned this pull request Nov 7, 2023
Closed
romac added a commit that referenced this pull request Nov 8, 2023
@romac @ancazamfir
code: Events and SM improvements (#19)
643a84e 
* Event name changes and other small fixes

* Add event multiplexing in executor and fix tests

* Fix formatting

* Fix executor handling of new round

* Fix executor initialization

* Add test step for NewRound, fix precommit for nil quorum to emit PrecommitAny

* Review comments

* Remove dead code

---------

Co-authored-by: Anca Zamfir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @ancazamfir