Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different types for the executors inputs and outputs #17

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 25, 2023

This allows to cleanly differentiate output messages which need to be acted on by a runtime (eg. an async runtime which would schedule a timeout) and input messages which are solely processed by the executor.

@romac romac requested a review from ancazamfir October 25, 2023 13:02
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #17 (17ae258) into romac/rust-state-machine (4968797) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@                     Coverage Diff                      @@
##           romac/rust-state-machine      #17      +/-   ##
============================================================
- Coverage                     85.41%   85.35%   -0.06%     
============================================================
  Files                            17       17              
  Lines                           891      894       +3     
============================================================
+ Hits                            761      763       +2     
- Misses                          130      131       +1     
Files Coverage Δ
Code/consensus/src/executor.rs 88.15% <100.00%> (-0.49%) ⬇️
Code/round/src/message.rs 66.67% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac merged commit 5e5d175 into romac/rust-state-machine Oct 27, 2023
7 checks passed
@romac romac deleted the romac/executor-output branch October 27, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant