Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Sign votes and verify votes signatures #16

Merged
merged 10 commits into from
Oct 27, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 25, 2023

No description provided.

@romac romac requested a review from ancazamfir October 25, 2023 10:01
@romac romac marked this pull request as draft October 25, 2023 10:01
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #16 (f2ef506) into romac/rust-state-machine (5e5d175) will increase coverage by 0.66%.
The diff coverage is 93.42%.

@@                     Coverage Diff                      @@
##           romac/rust-state-machine      #16      +/-   ##
============================================================
+ Coverage                     85.35%   86.00%   +0.66%     
============================================================
  Files                            17       20       +3     
  Lines                           894      986      +92     
============================================================
+ Hits                            763      848      +85     
- Misses                          131      138       +7     
Files Coverage Δ
Code/common/src/signed_vote.rs 100.00% <100.00%> (ø)
Code/common/src/vote.rs 100.00% <ø> (ø)
Code/consensus/src/executor.rs 89.13% <100.00%> (+0.98%) ⬆️
Code/round/src/message.rs 66.67% <100.00%> (ø)
Code/round/src/state_machine.rs 61.99% <100.00%> (ø)
Code/test/src/consensus.rs 95.00% <100.00%> (+5.00%) ⬆️
Code/test/src/value.rs 88.46% <100.00%> (+1.51%) ⬆️
Code/test/src/vote.rs 94.12% <100.00%> (+2.69%) ⬆️
Code/common/src/round.rs 92.00% <50.00%> (ø)
Code/consensus/src/message.rs 0.00% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac marked this pull request as ready for review October 25, 2023 17:14
@romac romac force-pushed the romac/signed-vote branch from 99f33d5 to f6f72aa Compare October 27, 2023 10:17
@romac romac changed the title Introduce SignedVote type and remove address from round Vote Sign votes and verify votes signatures Oct 27, 2023
@romac romac force-pushed the romac/signed-vote branch from fe26a0d to 62c47df Compare October 27, 2023 13:25
@romac romac changed the title Sign votes and verify votes signatures executor: Sign votes and verify votes signatures Oct 27, 2023
@romac romac merged commit 39a2041 into romac/rust-state-machine Oct 27, 2023
7 checks passed
@romac romac deleted the romac/signed-vote branch October 27, 2023 15:08
romac added a commit that referenced this pull request Nov 8, 2023
* Introduce `SignedVote` type and remove address from round `Vote`

* Add facility for signing votes

* Verify votes signatures

* Better name for the module

* Doc comments

* Refactor signing facility into a `SigningScheme`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant