Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mugen1 "default" SP #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

two4teezee
Copy link

Moves the WinMugen screenpack def and sff's into a winmugen folder, and brings the "mugen1" def and sff's into ./data.

Since we are using mugen1 to showcase new features, it would make the most sense for it to be in ./data and not the WinMugen assets.

@potsmugen
Copy link
Contributor

I'm not sure if one of them is "more default" than the other. Maybe they could both be in subfolders since we don't own either of them for them to really feel default.

@two4teezee
Copy link
Author

two4teezee commented Sep 26, 2024

That makes sense. In that case I would agree with you - all of them in subfolders. It sounds like we use these mostly to showcase backwards compatibility, which is fine, but also a bit confusing.

That said, we should have a single reference implementation that we use to showcase all Ikemen features. This would be especially useful for folks developing game modes as modules. If we need to create something from scratch to which we have the proper rights, that is maybe something I can take on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants