Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ new ] Seq and BoundedQueue #11

Closed

Conversation

Matthew-Mosior
Copy link
Collaborator

@Matthew-Mosior Matthew-Mosior commented Jan 4, 2025

This PR adds BoundedQueue, which is like Queue, but has a bounded size.

Additionally, since Seq (unsized) is utilitzed to implement BoundedQueue, Data.Seq.Internal, Data.Seq.Sized, and Data.Seq.Unsized have been migrated from contrib into this PR.

@Matthew-Mosior Matthew-Mosior changed the title [new] BoundedQueue [ new ] BoundedQueue Jan 4, 2025
@Matthew-Mosior Matthew-Mosior marked this pull request as draft January 6, 2025 06:08
@Matthew-Mosior Matthew-Mosior changed the title [ new ] BoundedQueue [ new ] Seq and BoundedQueue Jan 6, 2025
@Matthew-Mosior Matthew-Mosior marked this pull request as ready for review January 6, 2025 06:42
@Matthew-Mosior
Copy link
Collaborator Author

Matthew-Mosior commented Jan 6, 2025

@stefan-hoeck

This should be ready for you to review when you have time.

@stefan-hoeck
Copy link
Collaborator

Could you please split this into two separate PRs: One for the bounded queue and one for Seq? Also, we need to add tests to this library. I'll try and setup a some tests for the containers I wrote by the end of the week. Would be greate if you could then add similar tests (and additional ones - as needed) for your own.

@Matthew-Mosior
Copy link
Collaborator Author

Could you please split this into two separate PRs: One for the bounded queue and one for Seq? Also, we need to add tests to this library. I'll try and setup a some tests for the containers I wrote by the end of the week. Would be greate if you could then add similar tests (and additional ones - as needed) for your own.

Yep, I can split these into two PRs. Adding tests after sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants