Migrate to codespaces #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
reviewed
Jan 7, 2025
Comment on lines
+10
to
+13
| "download_bashrc": "cd ${HOME} && wget -O .bashrc_iCub https://raw.githubusercontent.com/icub-tech-iit/icub-os-files/master/user-environment/bashrc_iCub_superbuild", | ||
| "append_bashrc": "cd ${HOME} && printf \"if [ -f ~/.bashrc_iCub ]; then\n . ~/.bashrc_iCub\nfi\" | cat - ~/.bashrc > temp && mv temp ~/.bashrc && source ~/.bashrc && cd -", | ||
| "set_obj_subdir": "cd ~ && printf \"export OBJ_SUBDIR=build\n\" | cat - ~/.bashrc > temp && mv temp ~/.bashrc && source ~/.bashrc && cd -" | ||
| } |
There was a problem hiding this comment.
This is likely not correct as these commands need to be executed in a row, I suppose.
Instead, here each line runs into an independent terminal.
I'm afraid that it was the same in Gitpod so there was already a problem in the first place.
You could better churn out a setup.sh bash script (make it executable and put it under .devcontainer folder). Then, you can apply this refactoring:
"vnc": "start-vnc-session.sh",
"setup": "setup.sh"There was a problem hiding this comment.
Alternatively, you may embed those operations inside the Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, it fixes #12