Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage optimization in xcall #418

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Dec 2, 2024

Description:

Commit Message

fix: storage optimization in xcall

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.24%. Comparing base (2a357b9) to head (5f7cb9c).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #418      +/-   ##
============================================
- Coverage     89.60%   89.24%   -0.37%     
  Complexity       77       77              
============================================
  Files            43       43              
  Lines          2781     2939     +158     
  Branches         37       37              
============================================
+ Hits           2492     2623     +131     
- Misses          272      299      +27     
  Partials         17       17              
Flag Coverage Δ
solidity 87.88% <ø> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@gcranju gcranju added the enhancement New feature or request label Dec 2, 2024
@gcranju gcranju self-assigned this Dec 2, 2024
Copy link
Collaborator

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming there is not any unexpected issues in migration

@gcranju gcranju merged commit fbb070b into main Dec 3, 2024
18 of 19 checks passed
@gcranju gcranju deleted the fix/storage-optimization-xcall branch December 3, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants