Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track acknowledged packet state #415

Merged
merged 7 commits into from
Dec 16, 2024
Merged

fix: track acknowledged packet state #415

merged 7 commits into from
Dec 16, 2024

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Nov 28, 2024

Description:

Commit Message

fix: track acknowledged packet state

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@gcranju gcranju added the bug Something isn't working label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (a81c141) to head (5765e0c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #415   +/-   ##
=========================================
  Coverage     89.29%   89.29%           
  Complexity       77       77           
=========================================
  Files            43       43           
  Lines          2943     2943           
  Branches         37       37           
=========================================
  Hits           2628     2628           
  Misses          298      298           
  Partials         17       17           
Flag Coverage Δ
java 85.60% <ø> (ø)
solidity 88.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ibrizsabin ibrizsabin merged commit 8d50787 into main Dec 16, 2024
20 checks passed
@ibrizsabin ibrizsabin deleted the feat/icon-aggregator branch December 16, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants