Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add zero prefix for numeric types #370

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

bishalbikram
Copy link
Collaborator

@bishalbikram bishalbikram commented Sep 19, 2024

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (81f4cbd) to head (cbd3825).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #370   +/-   ##
=========================================
  Coverage     89.47%   89.47%           
  Complexity       77       77           
=========================================
  Files            42       42           
  Lines          2698     2698           
  Branches         37       37           
=========================================
  Hits           2414     2414           
  Misses          267      267           
  Partials         17       17           
Flag Coverage Δ
solidity 88.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gcranju gcranju added the bug Something isn't working label Sep 20, 2024
@gcranju gcranju changed the title Fix/add zero prefix for numeric types fix: add zero prefix for numeric types Sep 20, 2024
@gcranju gcranju merged commit 807bd92 into main Sep 20, 2024
22 of 29 checks passed
@gcranju gcranju deleted the fix/add-zero-prefix-for-numeric-types branch September 20, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants