fix: bug fixes in sui xcall #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrizsabin
approved these changes
May 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/sui-xcall-contracts #308 +/- ##
==============================================================
- Coverage 89.47% 83.72% -5.75%
Complexity 76 76
==============================================================
Files 42 42
Lines 2679 2679
Branches 37 37
==============================================================
- Hits 2397 2243 -154
- Misses 265 419 +154
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. |
gcranju
added a commit
that referenced
this pull request
Aug 8, 2024
* fix: set admin fixed * fix: get fee added in entry as well
gcranju
added a commit
that referenced
this pull request
Aug 8, 2024
* fix: set admin fixed * fix: get fee added in entry as well
gcranju
added a commit
that referenced
this pull request
Aug 8, 2024
* fix: set admin fixed * fix: get fee added in entry as well
ibrizsabin
added a commit
that referenced
this pull request
Aug 9, 2024
* feat: add connection template * feat: add states * fix: suppress warnings * fix: add get fee * feat: centralized connection added * feat: added some porion of xcall * feat: add rlp encoding (#288) * feat: add rlp * feat: add tests * fix: fixed double encoding * fix: upgrade move * fix: list encoding * test: add tests * feat: add encoding envelope * fix: get_rollback reference issue --------- Co-authored-by: gcranju <[email protected]> * fix: cargo fmt * feat: add mock dapp * feat: fix rollback struct * fix: some fix to xcall * feat: add mock dapp * fix: made send_call public * fix: made some variables mutable * fix: semicolons removed * fix: coin consumed in both if else * feat: state return added for testing * fix: interface for testing * fix: refactor send message * feat: fix conn receive * test: add receive message test * feat: add tests * feat: sui xcall test (#304) * feat: sui xcall unit test * feat: xcall flow tests added * fix: xcall flow tests, hex_encode_decode * feat: wrap persistent message method added in envelope * fix: cleanup * fix: add dapp entry * fix: add dapp entry * fix: cleanup imports * feat: add move script * feat: add move script * fix: remove duplicate store connection message sequence (#296) * feat: add id check * fix: openzeppelin version upgrade * fix: add txcontext * fix: add protocols in ticket * fix: get id cap * fix: vecmap insert issue fixed (#307) * fix: bug fixes in sui xcall (#308) * fix: set admin fixed * fix: get fee added in entry as well * fix: claim fee test added * fix: 0x issue resolved and tests added * chore: add unit test coverage (#289) * chore: add unit test for cosmwasm xcall lib * chore: update test coverage for cosmwasm xcall * chore: add test cases for solidity CallService * chore: add test cases for previous xcall version * fix: fix rlp decode * ci: add sui build and test job * fix: fix long list decode * fix: xcall deployment script * feat: rollback added * fix: rlp encoding decoding for large value fixed (#316) * fix: rlp encoding decoding for large value fixed Signed-off-by: gcranju <[email protected]> * fix: empty vector decode f800 issue --------- Signed-off-by: gcranju <[email protected]> * fix: missing implementation of handle-reply added (#317) * fix: reply state set * fix: store nid dynamically (#319) * fix: relayer set admin * fix: handle network address conversion * fix: 0x removed in sui addressed/ids * fix: get rollback message to rollback * fix: 0x issue resolved * fix: upgrade compatibility issue * fix: testnet deployment move toml * fix: removed logs * fix: 0x issue in handle message * fix: 0x issue in handle message * fix: message removed in rollback ticket * fix: formatting in sui address * fix: added param in rollback event * fix: message field added in rollback event * fix: relp encode to ensure javascore decode * fix: relp encode to ensure javascore decode * feat: add conncap * fix: tests * fix: refactor mutability * fix: cleanup * fix: fix mockdapp test * feat: dont require conn cap on read methods * fix: test fix * feat unit tests added * fix: rlp decoding issue for very large numbers fixed (#331) * fix: error message in execute call * fix: sui implementation changes docs (#332) * fix: sui implementation changes docs * fix: deployment/cap id things added * fix: update sui-xcall.md * fix: update sui-xcall.md * fix: multi protocol handle message * fix: comments from anton * fix: internal audit issues (#335) * fix: audit issues * fix: fix mockdapp test * fix: external audit fixes (#343) * feat: add tests * feat: add tests multi conn * feat: cleanup cmnts * fix: make mutable function package only and add test_only macro * fix: submodules fix * fix: fix public mutable and format --------- Signed-off-by: gcranju <[email protected]> Co-authored-by: gcranju <[email protected]> Co-authored-by: gcranju <[email protected]> Co-authored-by: undefined <[email protected]> Co-authored-by: Deepak Bomjan <[email protected]> Co-authored-by: gcranju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
fix: bug fixes in sui xcallsee the guidelines for commit messages.
Changelog Entry
Checklist: