Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: soroban xcall contracts #297

Merged
merged 48 commits into from
Sep 17, 2024
Merged

feat: soroban xcall contracts #297

merged 48 commits into from
Sep 17, 2024

Conversation

bishalbikram
Copy link
Collaborator

@bishalbikram bishalbikram commented Apr 15, 2024

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (3284b2f) to head (89e9ac8).
Report is 49 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #297       +/-   ##
=============================================
- Coverage     89.47%   69.33%   -20.15%     
+ Complexity       77       76        -1     
=============================================
  Files            42       42               
  Lines          2698     2638       -60     
  Branches         37       37               
=============================================
- Hits           2414     1829      -585     
- Misses          267      792      +525     
  Partials         17       17               
Flag Coverage Δ
solidity 88.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 15, 2024
@bishalbikram bishalbikram self-assigned this Apr 15, 2024
@bishalbikram bishalbikram marked this pull request as draft April 15, 2024 04:46
@bishalbikram bishalbikram marked this pull request as ready for review May 6, 2024 02:39
@bishalbikram bishalbikram removed the documentation Improvements or additions to documentation label May 6, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 6, 2024
@ibrizsabin ibrizsabin self-requested a review May 8, 2024 07:52
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to resolve.

contracts/soroban/README.md Outdated Show resolved Hide resolved
contracts/soroban/contracts/xcall/src/states.rs Outdated Show resolved Hide resolved
contracts/soroban/contracts/xcall/src/states.rs Outdated Show resolved Hide resolved
@bishalbikram bishalbikram force-pushed the soroban/xcall-multi branch from 153f225 to ed4f04a Compare May 17, 2024 07:09
@bishalbikram bishalbikram force-pushed the soroban/xcall-multi branch from ccfd2af to f14f88e Compare May 22, 2024 08:32
@gcranju gcranju force-pushed the soroban/xcall-multi branch 2 times, most recently from 313e913 to 06db41f Compare September 17, 2024 04:31
@gcranju gcranju force-pushed the soroban/xcall-multi branch from 06db41f to 4dd83e0 Compare September 17, 2024 04:32
@gcranju gcranju merged commit 44f947a into main Sep 17, 2024
11 of 16 checks passed
@gcranju gcranju deleted the soroban/xcall-multi branch September 17, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd documentation Improvements or additions to documentation feature scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants