feat: javascore dapp new message type #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcranju
requested review from
redlarva,
ibrizsabin,
nightowl121 and
AntonAndell
as code owners
…/javascore-dapp-new-message-type
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development/177-xcall-future-proof-messaging #248 +/- ##
===============================================================================
Coverage 69.33% 69.33%
Complexity 64 64
===============================================================================
Files 40 40
Lines 2195 2195
Branches 24 24
===============================================================================
Hits 1522 1522
Misses 663 663
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
AntonAndell
requested changes
Jan 22, 2024
AntonAndell
reviewed
Jan 24, 2024
|
|
||
| if (new String(_data).equals("reply-response")) { | ||
| // response message | ||
| _sendCallMessage(Context.getValue(), _from, new byte[] { 1, 2, 3 }, null); |
There was a problem hiding this comment.
User BigInteger.ZERO instead of Context.getValue. Just so it clear that it is supposed to be free
AntonAndell
merged commit 7b50c81
into
development/177-xcall-future-proof-messaging
13 of 14 checks passed
bishalbikram
pushed a commit
that referenced
this pull request
Oct 2, 2024
* feat: new Message type added in javascore * feat: new Message type added in javascore dapp * fix: unallowed method removed * feat: sendMessageAny added in javascore * fix: message type added in dapp * feat: add response ability * fix: set response value sent zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
feat: javascore dapp new message typesee the guidelines for commit messages.
Changelog Entry
Checklist: