feat: add centralized connections in solidity and java #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcranju
requested review from
redlarva,
ibrizsabin,
nightowl121 and
AntonAndell
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
============================================
+ Coverage 70.99% 71.46% +0.46%
Complexity 55 55
============================================
Files 34 35 +1
Lines 2010 2036 +26
Branches 34 34
============================================
+ Hits 1427 1455 +28
+ Misses 567 565 -2
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AntonAndell
reviewed
Nov 21, 2023
There was a problem hiding this comment.
https://github.com/icon-project/ibc-planning/blob/main/adr/XCall_centralized_connection.md
A few method are missing:
revertMessage
claimFees
getReceipt
...entralized-connection/src/main/java/xcall/adapter/centralized/XCallCentralizeConnection.java
Outdated
Show resolved
Hide resolved
...entralized-connection/src/main/java/xcall/adapter/centralized/XCallCentralizeConnection.java
Outdated
Show resolved
Hide resolved
...entralized-connection/src/main/java/xcall/adapter/centralized/XCallCentralizeConnection.java
Outdated
Show resolved
Hide resolved
...entralized-connection/src/main/java/xcall/adapter/centralized/XCallCentralizeConnection.java
Outdated
Show resolved
Hide resolved
...entralized-connection/src/main/java/xcall/adapter/centralized/XCallCentralizeConnection.java
Outdated
Show resolved
Hide resolved
redlarva
reviewed
Dec 6, 2023
...re/centralized-connection/src/main/java/xcall/adapter/centralized/CentralizedConnection.java
Outdated
Show resolved
Hide resolved
redlarva
suggested changes
Dec 11, 2023
...re/centralized-connection/src/main/java/xcall/adapter/centralized/CentralizedConnection.java
Outdated
Show resolved
Hide resolved
redlarva
reviewed
Dec 11, 2023
...re/centralized-connection/src/main/java/xcall/adapter/centralized/CentralizedConnection.java
Outdated
Show resolved
Hide resolved
Co-authored-by: redlarva <[email protected]>
* fix: architecture updated * fix: use connectio sn * style: formatting code
gcranju
force-pushed
the
feat/centralizeed_connections
branch
from
4efbeb7 to
a5a6b1a
Compare
gcranju
added a commit
that referenced
this pull request
Dec 29, 2023
* feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
AntonAndell
added a commit
that referenced
this pull request
Jan 18, 2024
* feat: xcall upgradeable (#179) * feat: xcall upgradeable * fix: foundry toml fix * deploy mock script * fix: remapping * fix: env name changed * fix: script reformed * fix: upgradeable using openzeppelin * fix: upgradeable using openzeppelin * fix: deploy scripts fix * fix: deploy scripts fix * forge install: openzeppelin-foundry-upgrades * fix: Make simple dapp to use same logic as dapp multi (#195) * fix: adapters deployment scripts added * fix: adapters included in script --------- Co-authored-by: AntonAndell <[email protected]> * fix: network address validation fixed (#212) * fix: not authorized issue by making handleMessage public (#202) * fix: not authorized issue by making handleMessage public * feat: handleBTPMessage tests added * fix: add fixes for handle Error * fix: code order optmization in handle message Signed-off-by: gcranju <[email protected]> * fix:revert message added in handleRequest * fix: versions openzeppelin fix * fix: foundry upgrades deleted --------- Signed-off-by: gcranju <[email protected]> * ci: add job to update CHANGELOG.md (#207) * fix: added rpsc in foundry.toml * fix: fix env.example * fix: new message type added in solidity * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: unnecessary event log removed * fix: sendBTPMessage renamed to sendToConnection * fix: unnecessary event log removed * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: centralized-connection test fixed * fix: proxy request structure with data hash added * fix: getFee method * fix: message encoding decoding fixed * fix: logs removed * feat: persistent messaging added in solidity * fix: foundry upgradeable version * fix: review changes on persistent messaging --------- Signed-off-by: gcranju <[email protected]> Co-authored-by: AntonAndell <[email protected]> Co-authored-by: DeepakBomjan <[email protected]> Co-authored-by: izyak <[email protected]> Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
AntonAndell
added a commit
that referenced
this pull request
Jan 18, 2024
* feat: xcall upgradeable (#179) * feat: xcall upgradeable * fix: foundry toml fix * deploy mock script * fix: remapping * fix: env name changed * fix: script reformed * fix: upgradeable using openzeppelin * fix: upgradeable using openzeppelin * fix: deploy scripts fix * fix: deploy scripts fix * forge install: openzeppelin-foundry-upgrades * fix: Make simple dapp to use same logic as dapp multi (#195) * fix: adapters deployment scripts added * fix: adapters included in script --------- Co-authored-by: AntonAndell <[email protected]> * fix: network address validation fixed (#212) * fix: not authorized issue by making handleMessage public (#202) * fix: not authorized issue by making handleMessage public * feat: handleBTPMessage tests added * fix: add fixes for handle Error * fix: code order optmization in handle message Signed-off-by: gcranju <[email protected]> * fix:revert message added in handleRequest * fix: versions openzeppelin fix * fix: foundry upgrades deleted --------- Signed-off-by: gcranju <[email protected]> * ci: add job to update CHANGELOG.md (#207) * fix: added rpsc in foundry.toml * fix: fix env.example * fix: new message type added in solidity * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: unnecessary event log removed * fix: sendBTPMessage renamed to sendToConnection * fix: unnecessary event log removed * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: centralized-connection test fixed * fix: proxy request structure with data hash added * fix: getFee method * fix: message encoding decoding fixed * fix: logs removed * feat: response message solidity * fix: review changes * feat: tests added * fix merge issues --------- Signed-off-by: gcranju <[email protected]> Co-authored-by: AntonAndell <[email protected]> Co-authored-by: DeepakBomjan <[email protected]> Co-authored-by: izyak <[email protected]> Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
feat: add centralized connections in solidity and javasee the guidelines for commit messages.
Changelog Entry
Checklist: