Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent networkId to be from native chain when receiving call messsages. #166

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Nov 8, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have documented my code in accordance with the documentation guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 8, 2023
@AntonAndell AntonAndell added bug Something isn't working and removed documentation Improvements or additions to documentation labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #166 (7ff308f) into main (99a582c) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #166      +/-   ##
============================================
- Coverage     69.00%   68.83%   -0.18%     
  Complexity       55       55              
============================================
  Files            32       32              
  Lines          1926     1925       -1     
  Branches         34       34              
============================================
- Hits           1329     1325       -4     
- Misses          581      584       +3     
  Partials         16       16              
Flag Coverage Δ
rust 67.63% <0.00%> (-0.22%) ⬇️
solidity 65.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ts/cosmwasm-vm/cw-xcall/src/handle_call_message.rs 8.91% <0.00%> (+1.32%) ⬆️

... and 2 files with indirect coverage changes

@AntonAndell AntonAndell force-pushed the fix/add-network-id-check-in-handleMessage branch from e17d8fe to 3c7ce45 Compare November 8, 2023 08:47
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 8, 2023
@AntonAndell AntonAndell linked an issue Nov 8, 2023 that may be closed by this pull request
@AntonAndell AntonAndell changed the title fix: Prevent networkId to be from native chain when receiving call messsages. fix: Prevent networkId to be from native chain when receiving call messsages. Nov 8, 2023
@AntonAndell AntonAndell force-pushed the fix/add-network-id-check-in-handleMessage branch 2 times, most recently from fbd6747 to 6d6183a Compare November 8, 2023 09:09
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Nov 8, 2023
@AntonAndell
Copy link
Collaborator Author

99a582c

@AntonAndell AntonAndell force-pushed the fix/add-network-id-check-in-handleMessage branch from 6d6183a to 93860b0 Compare November 8, 2023 09:16
@pragyanshrestha-ibriz pragyanshrestha-ibriz added the Prod Support Issues relating to Prod Support label Nov 8, 2023
@AntonAndell AntonAndell force-pushed the fix/add-network-id-check-in-handleMessage branch from 93860b0 to 7ff308f Compare November 8, 2023 10:31
@ibrizsabin ibrizsabin merged commit f94e6b2 into main Nov 8, 2023
15 of 17 checks passed
@ibrizsabin ibrizsabin deleted the fix/add-network-id-check-in-handleMessage branch November 8, 2023 10:49
ibrizsabin added a commit that referenced this pull request Nov 8, 2023
* docs: add deployment addresses (#153)

* Create contract-addresses.json

* fix: fix space

---------

Co-authored-by: ibrizsabin <[email protected]>

* fix: use constant version of [email protected] for build (#163)

* fix: Prevent networkId to be from native chain when receiving call messsages. (#166)

---------

Co-authored-by: CyrusVorwald <[email protected]>
Co-authored-by: ibrizsabin <[email protected]>
Co-authored-by: redlarva <[email protected]>
Co-authored-by: AntonAndell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prod Support Issues relating to Prod Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafe recommendation when handling rollbacks
3 participants