Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change xcall btp service name to xcallM #152

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Oct 24, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #152 (ca912a9) into main (6779754) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #152   +/-   ##
=========================================
  Coverage     68.00%   68.00%           
  Complexity       54       54           
=========================================
  Files            32       32           
  Lines          1919     1919           
  Branches         33       33           
=========================================
  Hits           1305     1305           
  Misses          598      598           
  Partials         16       16           
Flag Coverage Δ
java 81.40% <ø> (ø)
solidity 62.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AntonAndell AntonAndell added the enhancement New feature or request label Oct 24, 2023
@AntonAndell AntonAndell force-pushed the 150-change-xcall-service-name-to-be-alphanumeric-xcallm-xcall2-or-xcallmulti branch from b36dfb3 to ca912a9 Compare October 27, 2023 07:15
@AntonAndell AntonAndell changed the title feat: Change xcall btp service name to xcall2 feat: Change xcall btp service name to xcallM Oct 27, 2023
Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@AntonAndell AntonAndell merged commit ce37aa7 into main Oct 30, 2023
20 checks passed
@AntonAndell AntonAndell deleted the 150-change-xcall-service-name-to-be-alphanumeric-xcallm-xcall2-or-xcallmulti branch October 30, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change xcall service name to be alphanumeric xcallM, xcall2 or xcallMulti
2 participants